You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fnmain(){// types for clarityletmut x:String = "hello".to_string();
x.push('x');{let y:&mutString = &mut x;// y.push('x');println!("{}", y);}{// warning: variable does not need to be mutableletmut z:&mutString = &mut x;// z.push('x'); // this line disables the warningprintln!("{}", z);}}
Mutability of the reference itself isn't needed for z.push('x'). Then the behavior in two nested blocks is inconsistent: mut in let mut z is, in fact, unneeded, either when doing z.push('x') or when not doing it. Only the underlying String has to be mutable. But the compiler doesn't warn about it.
I expected the warning "variable does not need to be mutable" to be emitted even when z.push('x'); line is uncommented.
The text was updated successfully, but these errors were encountered:
Fixed mutable vars being marked used when they weren't
#### NB : bootstrapping is slow on my machine, even with `keep-stage` - fixes for occurances in the current codebase are <s>in the pipeline</s> done. This PR is being put up for review of the fix of the issue.
Fixes#43526, Fixes#30280, Fixes#25049
### Issue
Whenever the compiler detected a mutable deref being used mutably, it marked an associated value as being used mutably as well. In the case of derefencing local variables which were mutable references, this incorrectly marked the reference itself being used mutably, instead of its contents - with the consequence of making the following code emit no warnings
```
fn do_thing<T>(mut arg : &mut T) {
... // don't touch arg - just deref it to access the T
}
```
### Fix
Make dereferences not be counted as a mutable use, but only when they're on borrows on local variables.
#### Why not on things other than local variables?
* Whenever you capture a variable in a closure, it gets turned into a hidden reference - when you use it in the closure, it gets dereferenced. If the closure uses the variable mutably, that is actually a mutable use of the thing being dereffed to, so it has to be counted.
* If you deref a mutable `Box` to access the contents mutably, you are using the `Box` mutably - so it has to be counted.
`iter_mut()` and `or_insert()` yields mutable references, the variables
they bind to does not need to be mutable.
Previously, because of rust-lang/rust#30280
this was not considered a warning.
The fix is in rust-lang/rust#43582
This means on recently nightlies this warning is emitted.
Consider this code (playpen):
Mutability of the reference itself isn't needed for
z.push('x')
. Then the behavior in two nested blocks is inconsistent:mut
inlet mut z
is, in fact, unneeded, either when doingz.push('x')
or when not doing it. Only the underlyingString
has to be mutable. But the compiler doesn't warn about it.I expected the warning "variable does not need to be mutable" to be emitted even when
z.push('x');
line is uncommented.The text was updated successfully, but these errors were encountered: