Skip to content

Test in libsyntax doesn't call abort_if_errors #6416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pcwalton opened this issue May 11, 2013 · 1 comment
Closed

Test in libsyntax doesn't call abort_if_errors #6416

pcwalton opened this issue May 11, 2013 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@pcwalton
Copy link
Contributor

As per https://github.com/pcwalton/rust/blob/6f98fa372d898932c3420a92da581c8fa6342ab0/src/libsyntax/parse/mod.rs#L479

The test causes a parse error, but this isn't turned into a failure-failure properly (requires calling abort_if_errors) so the #[should_fail] annotation doesn't work right. The parse "succeeds".

@graydon
Copy link
Contributor

graydon commented Jul 25, 2013

Visiting for triage. Reproduced, rewrite bug to reflect proper state of affairs. Made fix. Testing now, PR in the queue.

flip1995 pushed a commit to flip1995/rust that referenced this issue Dec 6, 2020
Moved map_err_ignore to restriction and updated help message

This MR moves map_err_ignore lint from `pedantic` to the `restriction` category of lints and updates the help message to give the user an option to ignore the lint by naming the closure variable e.g. `.map_err(|_ignored| ...`

---

changelog: move map_err_ignore to restriction category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Development

No branches or pull requests

2 participants