Skip to content

rustfmt no longer builds after rust-lang/rust#73190 #73200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rust-highfive opened this issue Jun 10, 2020 · 0 comments · Fixed by #73506
Closed

rustfmt no longer builds after rust-lang/rust#73190 #73200

rust-highfive opened this issue Jun 10, 2020 · 0 comments · Fixed by #73506
Assignees
@topecongiro
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #73190, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @Dylan-DPC, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.
@rust-highfive rust-highfive added the C-bug Category: This is a bug. label Jun 10, 2020
@calebcartwright calebcartwright mentioned this issue Jun 11, 2020
Merged
ghedo added a commit to cloudflare/quiche that referenced this issue Jun 11, 2020
@ghedo
travis: pin Rust nightly version
45e5f23 
rustfmt is yet again broken in the latest nightly, so pin the rust
version to the last known good one.

Can revert once rust-lang/rust#73200 is fixed.
@ghedo ghedo mentioned this issue Jun 11, 2020
Merged
ghedo added a commit to cloudflare/quiche that referenced this issue Jun 11, 2020
@ghedo
travis: pin Rust nightly version
604b6dd 
rustfmt is yet again broken in the latest nightly, so pin the rust
version to the last known good one.

Can revert once rust-lang/rust#73200 is fixed.
This was referenced Jun 11, 2020
Closed
Merged
Merged
Closed
Closed
@Xanewok Xanewok mentioned this issue Jun 19, 2020
Merged
@bors bors closed this as completed in 3e40cca Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topecongiro topecongiro

Labels
C-bug Category: This is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Rustfmt and RLS Xanewok/rust
2 participants
@rust-highfive @topecongiro