Skip to content

rustpkg test package_script_with_default_build makes bogus assumptions about the build directory layout #8690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
msullivan opened this issue Aug 22, 2013 · 2 comments
Closed

rustpkg test package_script_with_default_build makes bogus assumptions about the build directory layout #8690

msullivan opened this issue Aug 22, 2013 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc

Comments

@msullivan
Copy link
Contributor

The test package_script_with_default_build in rustpkg is busted. It needs to access a file in the source distribution, which it finds based on the test executable path. This doesn't work because it relies on a particular directory layout of the build directory. (Namely, that the root build directory is a subdirectory inside the source directory.)
@ghost ghost assigned catamorphism Aug 22, 2013
msullivan added a commit to msullivan/rust that referenced this issue Aug 22, 2013
@msullivan
Suppress a broken test. Issue rust-lang#8690.
7b08b2c
@huonw
Copy link
Member

huonw commented Jan 19, 2014

triage, test is still #[ignore]'d.

@thestinger
Copy link
Contributor

rustpkg is gone

flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 21, 2022
@bors
Auto merge of rust-lang#8690 - mucinoab:DoNot-rest_pat_in_fully_bound…
849668a 
…_structs-OnNonExhaustive, r=Manishearth

Do not trigger ``[`rest_pat_in_fully_bound_structs`]`` on `#[non_exhaustive]` structs

fixes rust-lang#8029

Just adds an additional check to ensure that the`ty::VariantDef` is not marked as `#[non_exhaustive]`.

changelog: Do not apply ``[`rest_pat_in_fully_bound_structs`]`` on structs marked as non exhaustive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@msullivan @catamorphism @huonw @thestinger