Skip to content

Add placeholder text to the search bar in the documentation. #10759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2013

Conversation

SiegeLord
Copy link
Contributor

This makes the search bar more visible.

@@ -59,7 +59,8 @@ pub fn render<T: fmt::Default, S: fmt::Default>(
<nav class=\"sub\">
<form class=\"search-form js-only\">
<input class=\"search-input\" name=\"search\"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a type="search" here while you're at it? It's needed to get the proper style on some browser platforms (Apple).

http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#text-(type=text)-state-and-search-state-(type=search)

bors added a commit that referenced this pull request Dec 3, 2013
This makes the search bar more visible.
@bors bors closed this Dec 3, 2013
@bors bors merged commit e73d506 into rust-lang:master Dec 3, 2013
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 31, 2023
Now `option_env_unwrap` warns even if a variable isn't set at compiletime

Fixes rust-lang#10742
changelog: Fix false negative where `option_env_unwrap` wouldn't warn if the env variable isn't set at compile-time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants