Remove wasm legacy abi #133952

bjorn3 · 2024-12-06T09:17:59Z

Closes #122532
Closes #138762
Fixes #71871
#88152
Fixes #115666
Fixes #129486

rustbot · 2024-12-06T09:18:07Z

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-12-06T09:18:09Z

These commits modify compiler targets.
(See the Target Tier Policy.)

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

rustbot · 2024-12-06T09:46:52Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

f456ebf

daxpedda · 2024-12-16T07:05:10Z

#129630 needs to be reverted or adjusted as well.

bjorn3 · 2024-12-16T11:23:09Z

Removed the section in question.

RalfJung · 2025-01-08T18:27:47Z

compiler/rustc_ty_utils/src/abi.rs

-
-                        match spec_abi {
-                            ExternAbi::Unadjusted => {}
-                            ExternAbi::PtxKernel => {}


Is the PtxKernel exception not needed any more?

To avoid conflicts I based this PR on #133932 which is the PR for making extern "ptx-kernel" have the right abi.

bors · 2025-02-06T00:51:31Z

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2025-02-07T17:02:24Z

☔ The latest upstream changes (presumably #136684) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2025-06-05T15:39:37Z

Out of curiosity, @bjorn3 did you (or anyone else?) have an expected timeline of when to land this? In the blog post this was slated for "mid summer" which is IMO any time around now, so at least personally I'd be in support of merging this change at any point now. I'm not sure if there are other stakeholders and thoughts though so wanted to confirm.

bjorn3 · 2025-06-05T16:00:38Z

It seems like the future incompat lint only recently started warning in dependencies, so I think we should at least wait until that change lands on stable.

alexcrichton · 2025-06-05T16:20:14Z

Oh? I thought that #138601, by nature of being a future-incompat lint, would warn on dependencies too, and that is on stable with 1.87 I believe. Was there a separate change though for specifically turning on the warning for dependencies? (or do you think it'd be best to wait another stable release or so?)

bjorn3 · 2025-06-05T17:03:43Z

It did. I think I got confused by the merge conflict caused by #141936.

rustbot · 2025-06-05T17:04:14Z

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

alexcrichton

r=me from my perspective as a maintainer of the wasm32-unknown-unknown target. I'm less certain that I have the authority to officially approve and equeue this, but I figure if no one else raises an objection or otherwise enqueues this in the next week or so I'm happy to send it to bors

alexcrichton · 2025-06-05T20:22:48Z

Also, would it make sense to put "Closes #138762" in the PR description too?

bjorn3 · 2025-06-05T20:42:15Z

Added that issue and #88152.

bors · 2025-06-13T21:06:33Z

☔ The latest upstream changes (presumably #142443) made this pull request unmergeable. Please resolve the merge conflicts.

alexcrichton · 2025-06-13T22:04:31Z

Ah ok it's been awhile now, so feel free to r=me with a rebase.

bjorn3 · 2025-06-14T09:58:09Z

@bors r=alexcrichton

bors · 2025-06-14T09:58:12Z

📌 Commit 4d536bd has been approved by alexcrichton

It is now in the queue for this repository.

…lexcrichton Remove wasm legacy abi Closes rust-lang#122532 Closes rust-lang#138762 Fixes rust-lang#71871 rust-lang#88152 Fixes rust-lang#115666 Fixes rust-lang#129486

Rollup of 10 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #134661 (Reduce precedence of expressions that have an outer attr) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141864 (Handle win32 separator for cygwin paths) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142377 (Try unremapping compiler sources) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142509 (bump std libc dependency) r? `@ghost` `@rustbot` modify labels: rollup

…lexcrichton Remove wasm legacy abi Closes rust-lang#122532 Closes rust-lang#138762 Fixes rust-lang#71871 rust-lang#88152 Fixes rust-lang#115666 Fixes rust-lang#129486

Rollup of 9 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141864 (Handle win32 separator for cygwin paths) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142377 (Try unremapping compiler sources) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142509 (bump std libc dependency) r? `@ghost` `@rustbot` modify labels: rollup

…lexcrichton Remove wasm legacy abi Closes rust-lang#122532 Closes rust-lang#138762 Fixes rust-lang#71871 rust-lang#88152 Fixes rust-lang#115666 Fixes rust-lang#129486

Rollup of 8 pull requests Successful merges: - #133952 (Remove wasm legacy abi) - #141769 (Move metadata object generation for dylibs to the linker code ) - #141864 (Handle win32 separator for cygwin paths) - #142347 (Async drop - fix for StorageLive/StorageDead codegen for pinned future) - #142389 (Apply ABI attributes on return types in `rustc_codegen_cranelift`) - #142470 (Add some missing mailmap entries) - #142481 (Add `f16` inline asm support for LoongArch) - #142509 (bump std libc dependency) r? `@ghost` `@rustbot` modify labels: rollup

bjorn3 added O-wasm Target: WASM (WebAssembly), http://webassembly.org/ A-ABI Area: Concerning the application binary interface (ABI) labels Dec 6, 2024

rustbot assigned cjgillot Dec 6, 2024

bjorn3 added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Dec 6, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 6, 2024

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 6, 2024

bjorn3 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 6, 2024

workingjubilee mentioned this pull request Dec 6, 2024

Make the wasm_c_abi future compat warning a hard error #133951

Merged

workingjubilee assigned alexcrichton and workingjubilee and unassigned cjgillot Dec 6, 2024

bjorn3 force-pushed the remove_wasm_legacy_abi branch from 88f79ac to 26c9b6e Compare December 6, 2024 09:46

bjorn3 marked this pull request as draft December 6, 2024 09:48

bjorn3 force-pushed the remove_wasm_legacy_abi branch from 26c9b6e to 16e660d Compare December 6, 2024 13:42

bjorn3 mentioned this pull request Dec 16, 2024

Status of rust+C bindings for wasm targets rustwasm/team#291

Open

RalfJung reviewed Jan 8, 2025

View reviewed changes

bjorn3 mentioned this pull request Jan 17, 2025

support wasm inline assembly in naked_asm! #135648

Merged

bjorn3 force-pushed the remove_wasm_legacy_abi branch from 6970f8d to e4c01de Compare January 26, 2025 14:21

bjorn3 force-pushed the remove_wasm_legacy_abi branch from e4c01de to e91711c Compare February 6, 2025 10:07

bjorn3 removed the has-merge-commits PR has merge commits, merge with caution. label Feb 21, 2025

bjorn3 force-pushed the remove_wasm_legacy_abi branch from e91711c to 106301d Compare February 28, 2025 09:09

bjorn3 marked this pull request as ready for review June 5, 2025 17:04

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2025

alexcrichton approved these changes Jun 5, 2025

View reviewed changes

bjorn3 added 2 commits June 14, 2025 09:57

Remove all support for wasm's legacy ABI

3e944fa

Remove outdated docs about broken ABI

4d536bd

bjorn3 force-pushed the remove_wasm_legacy_abi branch from f7a9002 to 4d536bd Compare June 14, 2025 09:57

fmease mentioned this pull request Jun 14, 2025

Rollup of 10 pull requests #142522

Closed

matthiaskrgr mentioned this pull request Jun 15, 2025

Rollup of 9 pull requests #142533

Closed

matthiaskrgr mentioned this pull request Jun 15, 2025

Rollup of 8 pull requests #142535

Open

Remove wasm legacy abi #133952

Are you sure you want to change the base?

Remove wasm legacy abi #133952

Conversation

bjorn3 commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 6, 2024

Uh oh!

rustbot commented Dec 6, 2024

Uh oh!

rustbot commented Dec 6, 2024

Uh oh!

daxpedda commented Dec 16, 2024

Uh oh!

bjorn3 commented Dec 16, 2024

Uh oh!

RalfJung Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

bjorn3 Jan 8, 2025

Choose a reason for hiding this comment

Uh oh!

bors commented Feb 6, 2025

Uh oh!

bors commented Feb 7, 2025

Uh oh!

alexcrichton commented Jun 5, 2025

Uh oh!

bjorn3 commented Jun 5, 2025

Uh oh!

alexcrichton commented Jun 5, 2025

Uh oh!

bjorn3 commented Jun 5, 2025

Uh oh!

rustbot commented Jun 5, 2025

Uh oh!

alexcrichton left a comment

Choose a reason for hiding this comment

Uh oh!

alexcrichton commented Jun 5, 2025

Uh oh!

bjorn3 commented Jun 5, 2025

Uh oh!

bors commented Jun 13, 2025

Uh oh!

alexcrichton commented Jun 13, 2025

Uh oh!

bjorn3 commented Jun 14, 2025

Uh oh!

bors commented Jun 14, 2025

Uh oh!

Uh oh!

bjorn3 commented Dec 6, 2024 •

edited

Loading