[WIP] Enable automatic cross-compilation in run-make tests #139244

jieyouxu · 2025-04-02T09:16:11Z

Caution

Stacked on top of #142414, needs rebase.

Supersedes #138066.

Blocker for #141856.

Based on #138066 with #139242 + #139239 cherry-picked in, plus rustdoc() cross-compile changes.

r? @ghost

try-job: armhf-gnu
try-job: test-various

jieyouxu · 2025-04-02T09:16:27Z

@bors try

…<try> [WIP] [WIP] Enable automatic cross-compilation in run-make tests WIP for the WIP rust-lang#138066. Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1

bors · 2025-04-02T09:17:38Z

⌛ Trying commit c09efec with merge a0afa67...

bors · 2025-04-02T09:41:07Z

💔 Test failed - checks-actions

bors · 2025-04-02T19:07:06Z

☔ The latest upstream changes (presumably #139257) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2025-04-04T03:20:01Z

@bors try

…<try> [WIP] [WIP] Enable automatic cross-compilation in run-make tests WIP for the WIP rust-lang#138066. Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: i686-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1

bors · 2025-04-04T03:21:13Z

⌛ Trying commit 9140e31 with merge a58362d...

bors · 2025-04-04T03:43:55Z

💔 Test failed - checks-actions

jieyouxu · 2025-04-07T07:05:40Z

Aaaaa I accidentally clicked again 💀

bors · 2025-04-12T21:05:22Z

☔ The latest upstream changes (presumably #139242) made this pull request unmergeable. Please resolve the merge conflicts.

…=<try> [WIP] Enable automatic cross-compilation for run-make rustdoc tests Extracted out of rust-lang#139244. Helps with rust-lang#138066. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1

jieyouxu · 2025-04-13T03:06:33Z

@bors try

bors · 2025-04-13T03:07:43Z

⌛ Trying commit 520d534 with merge 8efb167...

…<try> [WIP] [WIP] Enable automatic cross-compilation in run-make tests WIP for the WIP rust-lang#138066. Based on rust-lang#138066 with rust-lang#139242 + rust-lang#139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: x86_64-mingw-1 try-job: aarch64-apple try-job: x86_64-apple-1

rust-bors · 2025-06-16T13:43:40Z

⌛ Trying commit b674cb7 with merge 9394804…

To cancel the try build, run the command @bors2 try cancel.

[WIP] Enable automatic cross-compilation in run-make tests > [!CAUTION] > > Stacked on top of #142414, needs rebase. Supersedes #138066. Blocker for #141856. Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various

rust-bors · 2025-06-16T14:46:45Z

💔 Test failed

CI ❌

jieyouxu · 2025-06-16T15:03:48Z

@bors2 try

rust-bors · 2025-06-16T15:03:52Z

⌛ Trying commit 0a783ac with merge e68f86e…

To cancel the try build, run the command @bors2 try cancel.

[WIP] Enable automatic cross-compilation in run-make tests > [!CAUTION] > > Stacked on top of #142414, needs rebase. Supersedes #138066. Blocker for #141856. Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various

rust-bors · 2025-06-16T16:30:57Z

💔 Test failed

CI ❌

…ieyouxu ignore `run-make` tests that need `std` on targets without `std` In particular, anything that includes `none` in the target triple, and `nvptx64-nvidia-cuda`. Right now we don't cross-compile the `run-make` tests, but we want to in the future. This uses `//@ needs-target-std` introduced in rust-lang#142297. Useful for rust-lang#139244 and rust-lang#141856. The modified files are based on running rust-lang#141856 locally. It might be that rust-lang#139244 uncovers some additional files, but that PR needs to be rebased (though actually I'd advice to rebase the non-test changes onto this PR, probably faster that way). r? ``@jieyouxu`` <details> <summary>vim notes for future me</summary> Make a file with lines like this ``` /home/folkertdev/rust/rust/tests/run-make/export/disambiguator/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/invalid-so/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/no-builtins-attribute/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/export/extern-opt/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/link-dedup/rmake.rs:1:1 ``` then ``` :set errorformat=%f:%l:%c :cfile /tmp/files-to-fix.txt ``` ``` :copen :cnext :cprev ``` are your friends </details>

Rollup merge of #142414 - folkertdev:ignore-nostd-tests, r=jieyouxu ignore `run-make` tests that need `std` on targets without `std` In particular, anything that includes `none` in the target triple, and `nvptx64-nvidia-cuda`. Right now we don't cross-compile the `run-make` tests, but we want to in the future. This uses `//@ needs-target-std` introduced in #142297. Useful for #139244 and #141856. The modified files are based on running #141856 locally. It might be that #139244 uncovers some additional files, but that PR needs to be rebased (though actually I'd advice to rebase the non-test changes onto this PR, probably faster that way). r? ``@jieyouxu`` <details> <summary>vim notes for future me</summary> Make a file with lines like this ``` /home/folkertdev/rust/rust/tests/run-make/export/disambiguator/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/invalid-so/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/no-builtins-attribute/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/export/extern-opt/rmake.rs:1:1 /home/folkertdev/rust/rust/tests/run-make/link-dedup/rmake.rs:1:1 ``` then ``` :set errorformat=%f:%l:%c :cfile /tmp/files-to-fix.txt ``` ``` :copen :cnext :cprev ``` are your friends </details>

bors · 2025-06-16T21:59:20Z

☔ The latest upstream changes (presumably #142589) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu · 2025-06-16T23:45:03Z

@bors2 try

rust-bors · 2025-06-16T23:45:07Z

⌛ Trying commit 13f455d with merge 6ba5524…

To cancel the try build, run the command @bors2 try cancel.

[WIP] Enable automatic cross-compilation in run-make tests > [!CAUTION] > > Stacked on top of #142414, needs rebase. Supersedes #138066. Blocker for #141856. Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various

rust-bors · 2025-06-17T01:07:30Z

💔 Test failed

CI ❌

jieyouxu · 2025-06-17T01:25:23Z

@bors2 try

rust-bors · 2025-06-17T01:25:27Z

⌛ Trying commit 1bdac58 with merge 6de3fd8…

To cancel the try build, run the command @bors2 try cancel.

[WIP] Enable automatic cross-compilation in run-make tests > [!CAUTION] > > Stacked on top of #142414, needs rebase. Supersedes #138066. Blocker for #141856. Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various

rust-bors · 2025-06-17T02:55:06Z

💔 Test failed

CI ❌

jieyouxu · 2025-06-17T03:44:26Z

@bors2 try

rust-bors · 2025-06-17T03:44:29Z

⌛ Trying commit 7d54282 with merge 0f81339…

To cancel the try build, run the command @bors2 try cancel.

[WIP] Enable automatic cross-compilation in run-make tests > [!CAUTION] > > Stacked on top of #142414, needs rebase. Supersedes #138066. Blocker for #141856. Based on #138066 with #139242 + #139239 cherry-picked in, plus `rustdoc()` cross-compile changes. r? `@ghost` try-job: armhf-gnu try-job: test-various

rust-bors · 2025-06-17T05:09:13Z

💔 Test failed

CI ❌

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2025

jieyouxu added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2025

This comment has been minimized.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 2, 2025

jieyouxu force-pushed the exp/auto-cross-run-make branch from c09efec to 9140e31 Compare April 4, 2025 03:19

This comment has been minimized.

Sign in to view

jieyouxu requested a review from Copilot April 7, 2025 07:05

jieyouxu removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 7, 2025

This comment was marked as off-topic.

Sign in to view

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 12, 2025

jieyouxu force-pushed the exp/auto-cross-run-make branch from 9140e31 to 520d534 Compare April 13, 2025 02:39

jieyouxu mentioned this pull request Apr 13, 2025

[WIP] Enable automatic cross-compilation for run-make rustdoc tests #139731

Closed

jieyouxu force-pushed the exp/auto-cross-run-make branch from b674cb7 to 0a783ac Compare June 16, 2025 15:03

jieyouxu force-pushed the exp/auto-cross-run-make branch from 0a783ac to 5b2e664 Compare June 16, 2025 23:36

Kobzol and others added 2 commits June 17, 2025 07:38

Enable automatic cross-compilation in run-make tests

899b59c

Enable run-make-support auto cross-compilation for rustdoc too

fd0e0b3

jieyouxu force-pushed the exp/auto-cross-run-make branch from 5b2e664 to 13f455d Compare June 16, 2025 23:44

jieyouxu force-pushed the exp/auto-cross-run-make branch from 13f455d to 1bdac58 Compare June 17, 2025 01:25

Repair some run-make tests on cross-compile

7d54282

jieyouxu force-pushed the exp/auto-cross-run-make branch from 1bdac58 to 7d54282 Compare June 17, 2025 03:44

[WIP] Enable automatic cross-compilation in run-make tests #139244

Are you sure you want to change the base?

[WIP] Enable automatic cross-compilation in run-make tests #139244

Conversation

jieyouxu commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 2, 2025

Uh oh!

bors commented Apr 2, 2025

Uh oh!

jieyouxu commented Apr 4, 2025

Uh oh!

bors commented Apr 4, 2025

Uh oh!

This comment has been minimized.

bors commented Apr 4, 2025

Uh oh!

jieyouxu commented Apr 7, 2025

Uh oh!

This comment was marked as off-topic.

Uh oh!

bors commented Apr 12, 2025

Uh oh!

jieyouxu commented Apr 13, 2025

Uh oh!

bors commented Apr 13, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

jieyouxu commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

bors commented Jun 16, 2025

Uh oh!

jieyouxu commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 16, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

jieyouxu commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

jieyouxu commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

rust-bors bot commented Jun 17, 2025

Uh oh!

Uh oh!

jieyouxu commented Apr 2, 2025 •

edited

Loading