-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Cache subsequent re-runs of goals #141488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Cache subsequent re-runs of goals r? `@ghost`
This comment has been minimized.
This comment has been minimized.
Oops, we need to consider opaques too :^) |
783126a
to
0832a23
Compare
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
Cache subsequent re-runs of goals r? `@ghost`
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
[PERF] Don't rerun goals if none of their vars have changed r? `@ghost` Alternative to #141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
Finished benchmarking commit (ac8e859): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.7%, secondary -4.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -5.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 776.203s -> 778.048s (0.24%) |
#141500 is better |
[PERF] Don't rerun goals if none of their vars have changed r? `@ghost` Alternative to #141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
Don't rerun goals if none of their vars have changed r? `@ghost` Alternative to #141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
Don't rerun goals if none of their vars have changed r? `@ghost` Alternative to rust-lang/rust#141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
r? @ghost