Skip to content

Cache subsequent re-runs of goals #141488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

compiler-errors
Copy link
Member

r? @ghost

@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels May 24, 2025
@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 24, 2025
bors added a commit that referenced this pull request May 24, 2025
Cache subsequent re-runs of goals

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 24, 2025

⌛ Trying commit 783126a with merge de279a8...

@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member Author

Oops, we need to consider opaques too :^)

@compiler-errors
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

bors added a commit that referenced this pull request May 24, 2025
Cache subsequent re-runs of goals

r? `@ghost`
@bors
Copy link
Collaborator

bors commented May 24, 2025

⌛ Trying commit 0832a23 with merge ac8e859...

@bors
Copy link
Collaborator

bors commented May 24, 2025

☀️ Try build successful - checks-actions
Build commit: ac8e859 (ac8e85916e7f67ef7d131791122b3128469d0d28)

@rust-timer

This comment has been minimized.

bors added a commit that referenced this pull request May 24, 2025
[PERF] Don't rerun goals if none of their vars have changed

r? `@ghost`

Alternative to #141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ac8e859): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.3%, 1.2%] 7
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.5% [-9.3%, -1.0%] 5
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.7%, secondary -4.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.5%, 1.6%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.0% [-4.5%, -1.6%] 2
Improvements ✅
(secondary)
-4.8% [-4.8%, -4.8%] 1
All ❌✅ (primary) -0.7% [-4.5%, 1.6%] 4

Cycles

Results (secondary -5.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-6.2% [-7.9%, -2.6%] 5
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 776.203s -> 778.048s (0.24%)
Artifact size: 366.33 MiB -> 366.30 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 24, 2025
@compiler-errors
Copy link
Member Author

#141500 is better

bors added a commit that referenced this pull request May 25, 2025
[PERF] Don't rerun goals if none of their vars have changed

r? `@ghost`

Alternative to #141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
bors added a commit that referenced this pull request May 26, 2025
Don't rerun goals if none of their vars have changed

r? `@ghost`

Alternative to #141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request May 27, 2025
Don't rerun goals if none of their vars have changed

r? `@ghost`

Alternative to rust-lang/rust#141488. I'm pretty sure that we don't need to re-run the goal at all if the inputs don't change... 🤔
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
perf-regression Performance regression. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants