Rollup of 9 pull requests #142381
Merged
Rollup of 9 pull requests #142381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_id` in `EarlyContextAndPass` type
Signed-off-by: onur-ozkan <[email protected]>
…lyContextAndPass, r=oli-obk Remove unneeded `check_id` calls as they are already called in `visit_id` in `EarlyContextAndPass` type Follow-up from [this message](https://github.com/rust-lang/rust/pull/142240/files#r2137474724). Since `check_id` is already called in `visit_id` which is supposed to be called for each item with an ID, we don't need to manually call `check_id`. r? `@oli-obk`
remove ice group pings from `triagebot.toml` Followup to rust-lang/team#1860. Question: should the https://github.com/rust-lang/rust/labels/ICEBreaker-Cleanup-Crew and https://github.com/rust-lang/rust/labels/ICEBreaker-LLVM labels be deleted too or not?
…project, r=Kobzol remove myself from the project See [#t-infra/bootstrap > stepping down from T-Bootstrap](https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/stepping.20down.20from.20T-Bootstrap/with/523501689)
…import-to-execution-context, r=Kobzol Add tracing import to execution context In rust-lang#141909, we missed adding the trace_cmd import in the execution context module. This PR fixes that. Additionally, we are updating the mingw-check-2 check command to include BOOTSTRAP_TRACING=1 to help ensure we don't miss such cases in future PRs. r? `@Kobzol`
…fJung Fix enter_trace_span!() using wrong $crate paths This is a followup to rust-lang#140972, where I made a silly mistake and forgot to update `$crate::interpret::tracing_utils::...` to `$crate::interpret::util::...` inside the macro after moving the referenced code from `tracing_utils.rs` to `util.rs`. Sorry about this. r? `@RalfJung`
Add expectation for `{` when parsing lone coroutine qualifiers
Fixes rust-lang#80931
…ning-remove, r=RalfJung Do not warn on `rust.incremental` when using download CI rustc Discussed on Zulip. r? `@RalfJung`
Improve some attribute docs and rename groups r? `@nnethercote` Some naming here got changed at some point, and this feels more consistent. The docs changes were a direct response to `@mejrs` trying to implement a new parsers and running into this.
Fix missing newline trim in bootstrap Fixes [this comment](https://github.com/rust-lang/rust/pull/141909/files#r2140632918). Fixes: rust-lang#142350
|
@bors r+ rollup=never p=5 |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: e703dff8fe In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing e703dff (parent) -> 31d0d21 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 31d0d2123d36de10c2611b842299cce5f447ddf7 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
This was referenced Jun 12, 2025
|
Finished benchmarking commit (31d0d21): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -8.1%, secondary 2.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -4.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 754.802s -> 754.746s (-0.01%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
check_idcalls as they are already called invisit_idinEarlyContextAndPasstype #142305 (Remove unneededcheck_idcalls as they are already called invisit_idinEarlyContextAndPasstype)triagebot.toml#142314 (remove ice group pings fromtriagebot.toml){when parsing lone coroutine qualifiers #142362 (Add expectation for{when parsing lone coroutine qualifiers)rust.incrementalwhen using download CI rustc #142364 (Do not warn onrust.incrementalwhen using download CI rustc)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup