Skip to content

Miri subtree update #142556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 16, 2025
Merged

Miri subtree update #142556

merged 17 commits into from
Jun 16, 2025

Conversation

RalfJung
Copy link
Member

r? @ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 16, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 16, 2025

The Miri subtree was changed

cc @rust-lang/miri

@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

📌 Commit 5770b90 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2025
@RalfJung
Copy link
Member Author

@bors p=1

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

⌛ Testing commit 5770b90 with merge d9ca9bd...

@bors
Copy link
Collaborator

bors commented Jun 16, 2025

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d9ca9bd to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 16, 2025
@bors bors merged commit d9ca9bd into rust-lang:master Jun 16, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 16, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 68ac5ab (parent) -> d9ca9bd (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d9ca9bd014074e2bac567eaa2b66bfacb2591028 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-2: 3437.3s -> 5571.0s (62.1%)
  2. aarch64-apple: 4631.4s -> 5497.0s (18.7%)
  3. dist-apple-various: 6508.1s -> 7718.2s (18.6%)
  4. dist-x86_64-apple: 11073.5s -> 9374.0s (-15.3%)
  5. mingw-check-tidy: 78.6s -> 70.2s (-10.6%)
  6. x86_64-gnu-llvm-20-1: 3511.1s -> 3163.7s (-9.9%)
  7. dist-i686-linux: 5672.6s -> 6203.3s (9.4%)
  8. dist-powerpc64le-linux-gnu: 5030.0s -> 5358.6s (6.5%)
  9. dist-arm-linux-gnueabi: 4689.2s -> 4419.3s (-5.8%)
  10. x86_64-gnu-nopt: 5859.0s -> 6185.9s (5.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d9ca9bd): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -8.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-8.9% [-8.9%, -8.9%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 757.272s -> 756.489s (-0.10%)
Artifact size: 372.17 MiB -> 372.07 MiB (-0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants