Skip to content

Backport rust-lang/stdarch#1818 for 1.88 #142694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

Backport rust-lang/stdarch#1818 for 1.88 #142694

wants to merge 1 commit into from
+1 −1

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Jun 18, 2025

r? cuviper

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 18, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2025

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!
  • Some commits in this PR modify submodules.
  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

This was referenced Jun 20, 2025
Merged
Merged
@cuviper
Copy link
Member

cuviper commented Jun 20, 2025

I've included this in #142791.

@rustbot label beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 20, 2025
@Amanieu
Copy link
Member Author

Amanieu commented Jun 20, 2025

It would be useful to have another crater run with this backport, just in case.

@cuviper
Copy link
Member

cuviper commented Jun 20, 2025

Did it show up previously in crater? What do you expect to see (or not)?

@Amanieu
Copy link
Member Author

Amanieu commented Jun 20, 2025

There are actually 2 accidental stabilizations, done at separate times:

  • The vbsl intrinsics for f16 were accidentally stabilized in 1.88 (current beta).
  • The float16x{4,8}_t types were accidentally stabilized in 1.87 (current stable).

It is possible in theory that some people may be already using the float16xN_t types, although that is unlikely since all of the intrinsics that use this type are still unstable.

@cuviper
Copy link
Member

cuviper commented Jun 20, 2025

OK, but crater is still only x86-64 Linux AFAIK, so these aarch64 changes wouldn't show up anyway, right?

bors added a commit that referenced this pull request Jun 20, 2025
@bors
Auto merge of #142791 - cuviper:beta-next, r=cuviper
f1453a8 
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730

r? cuviper
rust-bors bot added a commit that referenced this pull request Jun 20, 2025
@rust-bors
Auto merge of #142791 - cuviper:beta-next, r=<try>
1a5e6ea 
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730

r? cuviper

try-job: x86_64-msvc-ext2
bors added a commit that referenced this pull request Jun 21, 2025
@bors
Auto merge of #142791 - cuviper:beta-next, r=cuviper
32084cf 
[beta] backports

- Make the assertion in `Ident::new` debug-only. #140880
- Avoid creating an empty identifer in `Symbol::to_ident_string`. #141318
- Backport rust-lang/stdarch#1818 for 1.88 #142694
- [beta] Clippy backport #142725
    - ICE:
        - rust-lang/rust-clippy#14776
    - Lint contradictions:
        - rust-lang/rust-clippy#14703
        - rust-lang/rust-clippy#14810
    - Smaller (in LoC changes) fixes:
        - rust-lang/rust-clippy#14733
        - rust-lang/rust-clippy#14730
-  [win][ci] Update LLVM toolchain used to build LLVM to 20 #140757

r? cuviper
@Amanieu
Copy link
Member Author

Amanieu commented Jun 21, 2025

OK, but crater is still only x86-64 Linux AFAIK, so these aarch64 changes wouldn't show up anyway, right?

Good point, I'd forgotten about that. Perhaps we could do an aarch64 check-only crater run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cuviper cuviper

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amanieu @rustbot @cuviper