mbe: Inline functions in `transcribe` that are only called once #142815

tgross35 · 2025-06-21T05:30:03Z

rust-lang/rust#142713 did some refactoring of macro expansion, which seems to have had an effect on performance. The only change was to split large functions into smaller ones, so mark some functions that are only called once #[inline] to make codegen more similar.

[142713] did some refactoring of macro expansion, which seems to have had an effect on performance. The only change was to split large functions into smaller ones, so mark some functions that are only called once `#[inline]` to make codegen more similar. [142713]: https://www.github.com/rust-lang/rust/pull/142713

rustbot · 2025-06-21T05:30:06Z

r? @compiler-errors

rustbot has assigned @compiler-errors.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35 · 2025-06-21T05:30:22Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-21T05:30:25Z

⌛ Trying commit 3a76b79 with merge ae84552…

To cancel the try build, run the command @bors2 try cancel.

mbe: Inline functions in `transcribe` that are only called once [#142713] did some refactoring of macro expansion, which seems to have had an effect on performance. The only change was to split large functions into smaller ones, so mark some functions that are only called once `#[inline]` to make codegen more similar. [#142713]: https://www.github.com/rust-lang/rust/pull/142713

rust-bors · 2025-06-21T07:58:38Z

☀️ Try build successful (CI)
Build commit: ae84552 (ae84552d1d14f25aade420c5a16f0a13fd2b8307, parent: 15c701fbc995eb6c5b3a86021c18185f8eee020d)

rust-timer · 2025-06-21T12:14:42Z

Finished benchmarking commit (ae84552): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.9%	[-2.9%, -2.9%]	1

Max RSS (memory usage)

Results (primary 7.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	7.2%	[7.2%, 7.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	7.2%	[7.2%, 7.2%]	1

Cycles

Results (primary -2.8%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-2.2%	[-2.3%, -2.1%]	3
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Binary size

Results (primary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.1%, -1.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.1%, -1.1%]	1

Bootstrap: 690.617s -> 691.665s (0.15%)
Artifact size: 371.83 MiB -> 371.86 MiB (0.01%)

tgross35 · 2025-06-24T07:29:10Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-24T07:29:14Z

⌛ Trying commit b9878b2 with merge 5a371e6…

To cancel the try build, run the command @bors2 try cancel.

mbe: Inline functions in `transcribe` that are only called once [#142713] did some refactoring of macro expansion, which seems to have had an effect on performance. The only change was to split large functions into smaller ones, so mark some functions that are only called once `#[inline]` to make codegen more similar. [#142713]: https://www.github.com/rust-lang/rust/pull/142713

tgross35 · 2025-06-24T07:37:01Z

@bors2 try cancel

rust-bors · 2025-06-24T07:37:04Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/15844152875

tgross35 · 2025-06-24T08:06:38Z

@bors2 try @rust-timer queue

mbe: Inline functions in `transcribe` that are only called once [#142713] did some refactoring of macro expansion, which seems to have had an effect on performance. The only change was to split large functions into smaller ones, so mark some functions that are only called once `#[inline]` to make codegen more similar. [#142713]: https://www.github.com/rust-lang/rust/pull/142713

rust-bors · 2025-06-24T16:52:38Z

⌛ Trying commit 0bd2f7a with merge 725536d…

To cancel the try build, run the command @bors2 try cancel.

rust-bors · 2025-06-24T19:22:38Z

☀️ Try build successful (CI)
Build commit: 725536d (725536d6534c0b0c5b2f5953357703bdf826ecbd, parent: 36b21637e93b038453924d3c66821089e71d8baa)

rust-timer · 2025-06-24T23:22:56Z

Finished benchmarking commit (725536d): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (primary -3.3%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.7%	[4.7%, 4.7%]	1
Improvements ✅ (primary)	-3.3%	[-3.3%, -3.3%]	1
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	-3.3%	[-3.3%, -3.3%]	1

Cycles

Results (primary -1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.8%, -0.5%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.2%	[-1.8%, -0.5%]	2

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 689.383s -> 689.503s (0.02%)
Artifact size: 371.94 MiB -> 371.93 MiB (-0.00%)

This reverts commit 0bd2f7a.

tgross35 · 2025-06-24T23:33:11Z

@bors2 try @rust-timer queue

rust-bors · 2025-06-24T23:33:15Z

⌛ Trying commit 8bfd405 with merge 155626a…

To cancel the try build, run the command @bors2 try cancel.

mbe: Inline functions in `transcribe` that are only called once [#142713] did some refactoring of macro expansion, which seems to have had an effect on performance. The only change was to split large functions into smaller ones, so mark some functions that are only called once `#[inline]` to make codegen more similar. [#142713]: https://www.github.com/rust-lang/rust/pull/142713

rust-bors · 2025-06-25T02:03:33Z

☀️ Try build successful (CI)
Build commit: 155626a (155626a7fa8a7535412f9116ea17328071eda438, parent: 28f1c807911c63f08d98e7b468cfcf15a441e34b)

rust-timer · 2025-06-25T05:00:49Z

Finished benchmarking commit (155626a): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-1.5%, -1.5%]	1
Improvements ✅ (secondary)	-0.9%	[-1.5%, -0.2%]	2
All ❌✅ (primary)	-1.5%	[-1.5%, -1.5%]	1

Max RSS (memory usage)

Results (primary -3.5%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.9%, 3.9%]	1
Improvements ✅ (primary)	-3.5%	[-3.5%, -3.5%]	1
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-3.5%	[-3.5%, -3.5%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 689.458s -> 689.738s (0.04%)
Artifact size: 372.01 MiB -> 372.01 MiB (-0.00%)

tgross35 · 2025-06-25T08:01:49Z

@bors2 try @rust-timer queue

rust-timer · 2025-06-25T08:01:52Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-bors · 2025-06-25T08:01:54Z

⌛ Trying commit 39bb3c7 with merge f506b04…

To cancel the try build, run the command @bors2 try cancel.

mbe: Inline functions in `transcribe` that are only called once [#142713] did some refactoring of macro expansion, which seems to have had an effect on performance. The only change was to split large functions into smaller ones, so mark some functions that are only called once `#[inline]` to make codegen more similar. [#142713]: https://www.github.com/rust-lang/rust/pull/142713

rust-bors · 2025-06-25T10:33:02Z

☀️ Try build successful (CI)
Build commit: f506b04 (f506b042b2135b475f6c9659f0890ac85dde9f49, parent: a17780db7b8eebbf42a1cbe6bc9cc83013820ba5)

rust-timer · 2025-06-25T10:33:05Z

Queued f506b04 with parent a17780d, future comparison URL.
There are currently 6 preceding artifacts in the queue.
It will probably take at least ~9.6 hours until the benchmark run finishes.

rustbot assigned compiler-errors Jun 21, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025

tgross35 marked this pull request as draft June 21, 2025 05:30