Skip to content

Add impl_trait_in_bindings tests from #61773 #142883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

mominul
Copy link
Contributor

@mominul mominul commented Jun 22, 2025

This adds the three test cases from the #61773 as was suggested by @lcnr.

I have merged the first two cases into one, named as region-lifetimes.rs

r? @lcnr

Closes #61773

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2025
@rustbot

This comment has been minimized.

@mominul mominul force-pushed the impl_in_bindings branch from 05257a5 to 49ab82f Compare June 22, 2025 16:30
@lcnr
Copy link
Contributor

lcnr commented Jun 23, 2025

r=me after nits

@bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

✌️ @mominul, you can now approve this pull request!

If @lcnr told you to "r=me" after making some further change, please make that change, then do @bors r=@lcnr

@mominul mominul force-pushed the impl_in_bindings branch from 49ab82f to 2973939 Compare June 24, 2025 13:57
@mominul
Copy link
Contributor Author

mominul commented Jun 24, 2025

I have applied your suggestions. Thanks! ❤️

@bors r=@lcnr

@bors
Copy link
Collaborator

bors commented Jun 24, 2025

📌 Commit 2973939 has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 24, 2025
Add impl_trait_in_bindings tests from rust-lang#61773

This adds the [three test cases](rust-lang#61773 (comment)) from the rust-lang#61773 as was suggested by `@lcnr.`

I have merged the first two cases into one, named as `region-lifetimes.rs`

r? `@lcnr`

Closes rust-lang#61773
bors added a commit that referenced this pull request Jun 24, 2025
Rollup of 9 pull requests

Successful merges:

 - #142645 (Also emit suggestions for usages in the `non_upper_case_globals` lint)
 - #142657 (mbe: Clean up code with non-optional `NonterminalKind`)
 - #142799 (rustc_session: Add a structure for keeping both explicit and default sysroots)
 - #142805 (Emit a single error when importing a path with `_`)
 - #142882 (Lazy init diagnostics-only local_names in borrowck)
 - #142883 (Add impl_trait_in_bindings tests from #61773)
 - #142943 (Don't include current rustc version string in feature removed help)
 - #142965 ([RTE-497] Ignore `c-link-to-rust-va-list-fn` test on SGX platform)
 - #142972 (Add a missing mailmap entry)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a73954c into rust-lang:master Jun 25, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 25, 2025
rust-timer added a commit that referenced this pull request Jun 25, 2025
Rollup merge of #142883 - mominul:impl_in_bindings, r=lcnr

Add impl_trait_in_bindings tests from #61773

This adds the [three test cases](#61773 (comment)) from the #61773 as was suggested by ``@lcnr.``

I have merged the first two cases into one, named as `region-lifetimes.rs`

r? ``@lcnr``

Closes #61773
@mominul mominul deleted the impl_in_bindings branch June 25, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

impl_trait_in_bindings and pick-constraint region bounds
4 participants