Skip to content

Rollup of 6 pull requests #142895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Jun 22, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

dpaoliello and others added 13 commits June 13, 2025 15:27
Co-authored-by: 许杰友 Jieyou Xu (Joe) <[email protected]>
Add an aarch64-msvc build running on ARM64 Windows

Resurrecting rust-lang#126341

Per <rust-lang/rfcs#3817> we intend to promote `aarch64-pc-windows-msvc` to Tier 1. As part of that work, we are adding a pre-merge CI job to validate that changes do not break this target.

Additionally, for consistency, the `dist-aarch64-msvc` job will also be run on Arm64 Windows runners.

r? `@Kobzol`

try-job: `*aarch64-msvc*`
…on, r=jieyouxu

Document subdirectories of UI tests with README files

Part of rust-lang#133895 and the [2025 Google Summer of Code](https://blog.rust-lang.org/2025/05/08/gsoc-2025-selected-projects/) associated project.

When adding a new UI test, one is faced with hundreds of subdirectories in `tests/ui` reflecting various categories. Knowing where to put the new test is not trivial, as many of the categories have slightly misleading names. For example, `moves` does not only refer to the `move` keyword but to functions taking ownership in general, whereas `allocator` does not refer to allocation in general but rather to the very specific `allocator_api` and `global_allocator` features.

Many contributors will therefore place their test at the top level of ̀`tests/ui` where it will be mixed with hundreds of unrelated tests.

This PR is a tentative move towards more clearly defined tag/categories, with a SUMMARY.md file documenting the true purpose of each subdirectory, placed inside `tests/ui`.

r? `@jieyouxu`
…r=jdonszelmann

Port `#[no_mangle]` to new attribute parsing infrastructure

Ports `no_mangle` to the new attribute parsing infrastructure for rust-lang#131229 (comment)

r? `@jdonszelmann`
…imulacrum

1.88.0 release notes

r? cuviper
…-alignment, r=workingjubilee

centralize `-Zmin-function-alignment` logic

tracking issue: rust-lang#82232
discussed in: rust-lang#142824 (comment)

Apply the `-Zmin-function-alignment` value to the alignment field of the function attributes when those are created, so that individual backends don't need to consider it.

The one exception right now is cranelift, because it can't yet set the alignment for individual functions, but it can (and does) set the global minimum function alignment.

cc `@RalfJung` I think this is an improvement regardless, is there anything else that should be done for miri?
…version-update, r=Kobzol

Check rustdoc-json-types FORMAT_VERSION is correctly updated

Follow-up of rust-lang#142677.

`@nnethercote` suggested that we should also ensure that the `FORMAT_VERSION` was only increased by 1 and we should check for it, this PR does it.

cc `@aDotInTheVoid`
r? ghost
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustc-dev-guide Area: rustc-dev-guide A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Jun 22, 2025
@jhpratt
Copy link
Member Author

jhpratt commented Jun 22, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jun 22, 2025

📌 Commit 646ec22 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2025
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 22, 2025
bors added a commit that referenced this pull request Jun 23, 2025
Rollup of 6 pull requests

Successful merges:

 - #140136 (Add an aarch64-msvc build running on ARM64 Windows)
 - #141597 (Document subdirectories of UI tests with README files)
 - #142823 (Port `#[no_mangle]` to new attribute parsing infrastructure)
 - #142828 (1.88.0 release notes)
 - #142854 (centralize `-Zmin-function-alignment` logic)
 - #142875 (Check rustdoc-json-types FORMAT_VERSION is correctly updated)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Collaborator

bors commented Jun 23, 2025

⌛ Testing commit 646ec22 with merge 8dcae0e...

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-msvc-2 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Rust is installed now. Great!

To get started you may need to restart your current shell.
This would reload its PATH environment variable to include
Cargo's bin directory (%USERPROFILE%\.cargo\bin).
---
  RUST_CONFIGURE_ARGS: --build=aarch64-pc-windows-msvc
  SCRIPT: make ci-msvc-ps1
  TOOLSTATE_PUBLISH: 1
##[endgroup]
Attempting with retry: curl -f https://ci-mirrors.rust-lang.org/rustc/LLVM-20.1.3-woa64.exe -o LLVM-20.1.3-woa64.exe
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
---
fpu  : yes
fpu_exception : yes
cpuid level : 12
wp  : yes
flags  : fpu tsc cx8 cmov clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid pni pclmuldq ssse3 cx16 sse4_1 sse4_2 popcnt aes lahf_lm 3dnowprefetch
bogomips : 6800.00
clflush size : 64
cache_alignment : 64
address sizes : 32 bits physical, 32 bits virtual
power management:
---
fpu  : yes
fpu_exception : yes
cpuid level : 12
wp  : yes
flags  : fpu tsc cx8 cmov clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid pni pclmuldq ssse3 cx16 sse4_1 sse4_2 popcnt aes lahf_lm 3dnowprefetch
bogomips : 6800.00
clflush size : 64
cache_alignment : 64
address sizes : 32 bits physical, 32 bits virtual
power management:
---
fpu  : yes
fpu_exception : yes
cpuid level : 12
wp  : yes
flags  : fpu tsc cx8 cmov clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid pni pclmuldq ssse3 cx16 sse4_1 sse4_2 popcnt aes lahf_lm 3dnowprefetch
bogomips : 6800.00
clflush size : 64
cache_alignment : 64
address sizes : 32 bits physical, 32 bits virtual
power management:
---
fpu  : yes
fpu_exception : yes
cpuid level : 12
wp  : yes
flags  : fpu tsc cx8 cmov clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid pni pclmuldq ssse3 cx16 sse4_1 sse4_2 popcnt aes lahf_lm 3dnowprefetch
bogomips : 6800.00
clflush size : 64
cache_alignment : 64
address sizes : 32 bits physical, 32 bits virtual
power management:
---
fatal runtime error: Rust cannot catch foreign exceptions, aborting
error: test failed, to rerun pass `-p rustc_thread_pool --lib`

Caused by:
  process didn't exit successfully: `C:\a\rust\rust\build\aarch64-pc-windows-msvc\stage1-rustc\aarch64-pc-windows-msvc\release\deps\rustc_thread_pool-acb7e49df0021259.exe -Z unstable-options --format json` (exit code: 0xc0000409, STATUS_STACK_BUFFER_OVERRUN)
note: test exited abnormally; to see the full output pass --nocapture to the harness.
Build completed unsuccessfully in 0:56:49
make: *** [Makefile:114: ci-msvc-ps1] Error 1
  local time: Mon Jun 23 03:35:59 CUT 2025
  network time: Mon, 23 Jun 2025 03:35:59 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

@bors
Copy link
Collaborator

bors commented Jun 23, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 23, 2025
@jhpratt jhpratt deleted the rollup-bepls8m branch June 23, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustc-dev-guide Area: rustc-dev-guide A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Development

Successfully merging this pull request may close these issues.