Skip to content

Remove unused feature gates #143169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2025
Merged

Conversation

yotamofek
Copy link
Contributor

@yotamofek yotamofek commented Jun 28, 2025

After finding some unused feature gates in #143155 , I wrote a small script to see if I can find any others.
And I did. Not a lot, but still a small win 😁
Contains a few instances of iter_from_coroutine that can be removed due to #142801 (I guess).

@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 28, 2025

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @TaKO8Ki

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 28, 2025

📌 Commit 492e04e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2025
@rust-log-analyzer

This comment has been minimized.

@yotamofek yotamofek force-pushed the pr/unneeded-features branch from 492e04e to 8429c99 Compare June 28, 2025 23:36
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 29, 2025

📌 Commit 8429c99 has been approved by compiler-errors

It is now in the queue for this repository.

bors added a commit that referenced this pull request Jun 29, 2025
Rollup of 11 pull requests

Successful merges:

 - #142021 (Doc: clarify priority of lint level sources)
 - #142367 (Add regression test for #137857 to ensure that we generate intra doc links for extern crate items.)
 - #142641 (Generate symbols.o for proc-macros too)
 - #142889 (Clarify doc comment on unix OpenOptions)
 - #143063 (explain `ImportData::imported_module`)
 - #143088 (Improve documentation of `TagEncoding`)
 - #143135 (fix typos on some doc comments)
 - #143138 (Port `#[link_name]` to the new attribute parsing infrastructure)
 - #143155 (`librustdoc` house-keeping 🧹)
 - #143169 (Remove unused feature gates)
 - #143171 (Fix the span of trait bound modifier `[const]`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 77757e7 into rust-lang:master Jun 29, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 29, 2025
rust-timer added a commit that referenced this pull request Jun 29, 2025
Rollup merge of #143169 - yotamofek:pr/unneeded-features, r=compiler-errors

Remove unused feature gates

After finding some unused feature gates in #143155 , I wrote a small script to see if I can find any others.
And I did. Not a lot, but still a small win 😁
Contains a few instances of `iter_from_coroutine` that can be removed due to #142801 (I guess).
@yotamofek yotamofek deleted the pr/unneeded-features branch June 29, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants