Fix soundness hole in struct with expressions, e.g. S{x:foo, .. y} #18672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20eb468 to
8f62f21
Compare
Fixes rust-lang#18567. Struct{x:foo, .. with_expr} did not walk with_expr, which allowed using moved variables in some cases. The CFG for structs also built up with with_expr happening before the fields, which is now reversed. (Fields are now before the with_expr in the CFG)
8f62f21 to
d80a62d
Compare
|
Just to keep a record: @nikomatsakis commented on an earlier version asking about comments that I'd accidentally left above the walk_expr change. They were just there to record the problems I was seeing with the CFG fixed as well, and have now been changed. |
|
r+ with clarification |
bors
added a commit
that referenced
this pull request
Nov 7, 2014
…matsakis Fixes #18567. `Struct{x:foo, .. with_expr}` did not walk `with_expr`, which allowed using moved variables in some cases. The CFG for structs also built up with `with_expr` happening before the fields, which is now reversed. (Fields are now before the `with_expr` in the CFG)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 16, 2024
internal: Do not require a special env var to be set for the proc-macro-srv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18567.
Struct{x:foo, .. with_expr}did not walkwith_expr, which allowedusing moved variables in some cases. The CFG for structs also built up with
with_exprhappening before the fields, which is now reversed. (Fields are nowbefore the
with_exprin the CFG)