Fix check for globally routable IPv4 address

[achanda]

• Adds two more functions for broadcast address and special
  address classes reserved for documentation
• Modifies the globally routable IP check to include these
  new functions

Fixes #24314

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

[alexcrichton]

Thanks! Could you add some tests for these as well?

[alexcrichton]

That'll work, but it's more conventional to put unit tests at the end of the module itself, so feel free to add something like this to the end of the module:

#[cfg(test)]
mod tests {
    #[test]
    fn foo() { /* ... */ }
}

[achanda]

@alexcrichton sorry, I deleted my earlier comment by mistake. I found existing tests for ip.rs in src/libstd/net/addr.rs, which looks like a wrong place for those tests. I think I will do this, add tests for the new methods in addr.rs and the move related tests to ip.rs in a separate commit. That way we do not clutter this commit. Let me know if this sounds good to you.

[alexcrichton]

Sounds great to me, thanks for the drive-by cleanup!

[achanda]

@alexcrichton this passes tests on my local machine. Please check.

[alexcrichton]

@bors: r+ f60f4b7

Thanks!

[achanda]

@alexcrichton How will this PR be merged? I did not see any job being run for this PR in buildbot. Do I need to do something else? Sorry, still new here :)

[alexcrichton]

Ah right, this is now in the queue and when it reaches the top @bors will comment that it's being tested. After that @bors will comment with the test results afterwards.

[achanda]

👍