Fix the asmjs C ABI #31653
Merged
Fix the asmjs C ABI #31653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
The two URLs I pasted in the source code don't pass |
|
I think you should use relative paths into the repo and maybe put a link to the whole repo on a different line. |
c68a0b9 to
c55ecde
Compare
c55ecde to
5b224ec
Compare
|
I'll be honest in that I have no idea what these files do, they're entirely black boxes to me, perhaps, though: r? @eddyb |
| ArgType::indirect(ty, Some(Attribute::StructRet)) | ||
| }, | ||
| _ => { | ||
| let attr = if ty == Type::i1(ccx) { Some(Attribute::ZExt) } else { None }; |
There was a problem hiding this comment.
i8 and others don't get extended?
|
This is good progress IMO, @bors r+ |
|
📌 Commit 5b224ec has been approved by |
bors
added a commit
that referenced
this pull request
Feb 15, 2016
Needs a correct review because I'm not too confident with how this works. All tests related to the C ABI are now passing. References: - https://github.com/kripken/emscripten-fastcomp-clang/blob/dbe68fecd03d6f646bd075963c3cc0e7130e5767/lib/CodeGen/TargetInfo.cpp#L479-L489 - https://github.com/kripken/emscripten-fastcomp-clang/blob/dbe68fecd03d6f646bd075963c3cc0e7130e5767/lib/CodeGen/TargetInfo.cpp#L466-L477 The `classifyArgumentType` function has two different paths depending on `RAA == CGCXXABI::RAA_DirectInMemory`, but I don't really know what's the corresponding option in Rust. cc @brson @eddyb
|
Neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a correct review because I'm not too confident with how this works.
All tests related to the C ABI are now passing.
References:
The
classifyArgumentTypefunction has two different paths depending onRAA == CGCXXABI::RAA_DirectInMemory, but I don't really know what's the corresponding option in Rust.cc @brson @eddyb