Skip to content

Support character range patterns (e.g. [0-9], [a-z]), like other globs do #9131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Dretch
Copy link
Contributor

@Dretch Dretch commented Sep 11, 2013

This feature was overlooked in the original pull request (#8914).

r? @alexcrichton

@huonw
Copy link
Member

huonw commented Sep 12, 2013

This doesn't support [a\-z] == a or - or z? (Just checking.)

@alexcrichton
Copy link
Member

@huonw, I believe that could be specified as [-az] or [az-] (requires the - be last or first)

@huonw
Copy link
Member

huonw commented Sep 12, 2013

Yeah, I was just comparing to e.g. bash, sed, etc, which support the backslash syntax.

@alexcrichton
Copy link
Member

Oh interesting, I didn't even know about that. Do they support escaping other characters as well? I supposed \ would need to be escaped, but possibly [ and ] too...

bors added a commit that referenced this pull request Sep 12, 2013
This feature was overlooked in the original pull request (#8914).

r? @alexcrichton
@bors bors closed this Sep 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants