Fix links #288
Merged
Fix links #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoxc
reviewed
Mar 16, 2019
| You can see an example of how to use them by looking at the `rustc_driver` implementation, | ||
| specifically the [`rustc_driver::run_compiler` function][rd_rc] (not to be confused with | ||
| `interface::run_compiler`). The `rustc_driver::run_compiler` function takes a bunch of | ||
| command-line args and some other configurations and drives the compilation to completion. |
There was a problem hiding this comment.
Maybe mention that rustc_driver::run_compiler takes a Callbacks type, which essentially replaces CompilerCalls + CompileController?
Zoxc
reviewed
Mar 16, 2019
src/appendix/stupid-stats.md
Outdated
| > a copy of the code on the GitHub repository. | ||
| > | ||
| > Due to the compiler's constantly evolving nature, the `rustc_driver` | ||
| > mechanisms described in this chapter have been replaced by a new |
There was a problem hiding this comment.
Not exactly true as rustc_driver still exposes a similar interface with run_compiler + Callbacks.
|
Thanks @Zoxc! I believe I have addressed your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the builds.
r? @Zoxc