Skip to content

comment-intentation regressions #4049

Closed
@Boscop

Description

@Boscop

After I updated to rustfmt 1.4.11-nightly (18382352 2019-12-03), I noticed some comment-intentation regressions:

Before:

			if let Some(MpcEv::PlayDrum(pitch, vel)) =
				// self.mpc.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
				self.mpc.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
			{

After:

			if let Some(MpcEv::PlayDrum(pitch, vel)) =
				// self.mpc.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
			 self.mpc.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
			{

And another one.
Before:

				if let Some(e) =
					// self.note_input.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
					self.note_input.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
				{

After:

				if let Some(e) =
					// self.note_input.handle_input(e, /*btn_ctrl_down,*/ tx_launch_to_daw, state_view)
				 self.note_input.handle_input(e, &mut MyBorrowedState { tx_launch_to_daw, state_view })
				{

Notice: It inserts a single space after tab-indentation.

These are my settings:

edition = "2018"
version = "Two"
max_width = 110
newline_style = "Unix"
use_small_heuristics = "Max"
hard_tabs = true
merge_imports = true
reorder_impl_items = true
use_field_init_shorthand = true
use_try_shorthand = true
spaces_around_ranges = true
overflow_delimited_expr = true

Metadata

Metadata

Assignees

No one assigned

    Labels

    1x-backport:pendingFixed/resolved in source but not yet backported to a 1x branch and release

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions