Skip to content

allocate 2 pages more than requested for guard pages #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2020
Merged

allocate 2 pages more than requested for guard pages #33

merged 1 commit into from
May 9, 2020

Conversation

semarie
Copy link
Contributor

@semarie semarie commented May 9, 2020

as there is two guard pages used (one on top, and another on bottom), two additionnals guard pages needs to be allocated.

@semarie semarie changed the title allocate 2 pages more that requested for guard pages allocate 2 pages more than requested for guard pages May 9, 2020
@semarie
Copy link
Contributor Author

semarie commented May 9, 2020

it is important at least on OpenBSD as the kernel will prevent stack overflow by killing the process with uncatchable signal.

as there is two guard pages used (one on top, and another on bottom), two additionnals guard pages needs to be allocated.
@nagisa nagisa merged commit 88f67c4 into rust-lang:master May 9, 2020
@semarie semarie deleted the guard_pages branch May 9, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants