Skip to content

[html] Add Social Media images #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yoshuawuyts opened this issue Nov 13, 2018 · 6 comments
Closed

[html] Add Social Media images #181

yoshuawuyts opened this issue Nov 13, 2018 · 6 comments
Labels
C-Bug Something isn't working.
Milestone
alpha launch

Comments

@yoshuawuyts
Copy link
Member

Just ran the site through metatags.io, and it looks like we're missing images. This should be high priority to solve before any launch happens.

Screenshot

Current
2018-11-13-192820_3840x2160

Expected (example)
2018-11-13-193000_3840x2160
@ashleygwilliams
Copy link
Member

i do know that the twitter card works, and when pasted in discord it shows a large rust logo:

screen shot 2018-11-13 at 1 35 25 pm

@ashleygwilliams
Copy link
Member

(not saying this is ideal but there's some functionality)

@ashleygwilliams ashleygwilliams added C-Bug Something isn't working. dev labels Nov 13, 2018
@ashleygwilliams ashleygwilliams added this to the alpha launch milestone Nov 13, 2018
@ashleygwilliams ashleygwilliams changed the title Add Social Media images [html] Add Social Media images Nov 13, 2018
@ashleygwilliams
Copy link
Member

assigning @yoshuawuyts since it's seems like you've got a good handle on what to improve here- lemme know if that's ok!

@yoshuawuyts
Copy link
Member Author

Happy to!

@yoshuawuyts yoshuawuyts mentioned this issue Nov 16, 2018
Merged
@yoshuawuyts
Copy link
Member Author

Dang, okay it seems like Facebook & LinkedIn really like large images. Need to do another pass on them. Also the twitter image is not showing up, but I suspect that's because it requires an absolute URL. Going to try that out.

Facebook

2018-11-16-204902_1920x1080

Twitter

2018-11-16-204908_1920x1080

LinkedIn

2018-11-16-204914_1920x1080

@yoshuawuyts yoshuawuyts mentioned this issue Nov 16, 2018
Merged
@yoshuawuyts
Copy link
Member Author

Okay, looks like it's all good now!

Twitter

2018-11-16-215118_1920x1080

Facebook

2018-11-16-215144_1920x1080

LinkedIn

2018-11-16-215156_1920x1080

@dtolnay dtolnay mentioned this issue Jul 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug Something isn't working.
Projects
None yet
Milestone
alpha launch
Development

No branches or pull requests
2 participants
@ashleygwilliams @yoshuawuyts