Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io-client-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7b3cc94
Choose a base ref
...
head repository: socketio/engine.io-client-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 9ae1c51
Choose a head ref
  • 5 commits
  • 7 files changed
  • 1 contributor

Commits on Dec 10, 2020

  1. Configuration menu
    Copy the full SHA
    475f89a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b1b7002 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. fix: check the type of the initial packet

    Before this fix, the client could mark the polling transport as open
    even though the handshake packet was not received properly (for
    example, after a parsing error).
    
    See also: socketio/engine.io-client@1c8cba8
    
    Backported from 2b5dfb9
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    319f2e2 View commit details
    Browse the repository at this point in the history
  2. fix: increase the readTimeout value of the default OkHttpClient

    With the previous value (10 seconds by default), a connection
    established with HTTP long-polling was closed if the server did not
    send any packet for 10 seconds (the HTTP request would timeout from the
    client side).
    
    It will now default to 1 minute, which is above the
    `pingInterval + pingTimeout` value from the server.
    
    Note: the connectTimeout and writeTimeout options are left as is (10
    seconds), but you may need to increase them depending on your use case:
    
    ```
    OkHttpClient client = new OkHttpClient.Builder()
    	.connectTimeout(20, TimeUnit.SECONDS)
    	.readTimeout(1, TimeUnit.MINUTES)
    	.writeTimeout(1, TimeUnit.MINUTES)
            .build();
    ```
    
    Related:
    
    - socketio/socket.io-client-java#491
    - socketio/socket.io-client-java#660
    
    Backported from fb531fa
    darrachequesne committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    2d87497 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ae1c51 View commit details
    Browse the repository at this point in the history
Loading