Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io-client-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fb1e448
Choose a base ref
...
head repository: socketio/engine.io-client-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7b3cc94
Choose a head ref
  • 7 commits
  • 11 files changed
  • 3 contributors

Commits on Jul 14, 2017

  1. Configuration menu
    Copy the full SHA
    559eb38 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. ci: migrate to GitHub Actions

    Due to the recent changes to the Travis CI platform (see [1]), we will
    now use GitHub Actions to run the tests.
    
    Note: the certificate was updated because it failed with newer Node.js versions
    
    ```
    _tls_common.js:129
          c.context.setCert(cert);
                    ^
    
    Error: error:140AB18F:SSL routines:SSL_CTX_use_certificate:ee key too small
        at Object.createSecureContext (_tls_common.js:129:17)
        at Server.setSecureContext (_tls_wrap.js:1328:27)
    ```
    
    Reference: https://docs.github.com/en/free-pro-team@latest/actions/guides/building-and-testing-java-with-maven
    
    [1]: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing
    darrachequesne committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    9a7176b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5c65197 View commit details
    Browse the repository at this point in the history
  3. fix: handle responses without content type (#101)

    This fixes NullPointerException when response doesn't have content type. Exception stack trace:
    
    ```
    java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.String okhttp3.MediaType.toString()' on a null object reference
            at io.socket.engineio.client.transports.PollingXHR$Request.onLoad(PollingXHR.java:271)
            at io.socket.engineio.client.transports.PollingXHR$Request.access$700(PollingXHR.java:148)
            at io.socket.engineio.client.transports.PollingXHR$Request$1.onResponse(PollingXHR.java:232)
            at okhttp3.RealCall$AsyncCall.execute(RealCall.java:141)
            at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
            at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
            at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
            at java.lang.Thread.run(Thread.java:764)
    ```
    Jacek Mleczek authored and darrachequesne committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    6f065b7 View commit details
    Browse the repository at this point in the history
  4. ci: add java 7 in the test matrix

    It was already present in the Travis test matrix.
    darrachequesne committed Dec 8, 2020
    Configuration menu
    Copy the full SHA
    180db95 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. chore: bump OkHttp client version

    Versions above 3.12.x have dropped support for Java 7.
    
    Related: https://square.github.io/okhttp/changelog_3x/#version-3130
    darrachequesne committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    8016a5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b3cc94 View commit details
    Browse the repository at this point in the history
Loading