Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.1.0
Choose a base ref
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.1.1
Choose a head ref
  • 3 commits
  • 6 files changed
  • 1 contributor

Commits on Feb 2, 2021

  1. fix: do not reset the ping timer after upgrade 

    There was two issues with this behavior:

- v3 clients (with allowEIO3: true) were also receiving a "ping" after
a successful upgrade, which is incorrect (in v3, it's the client that
sends the "ping", and the server answers with a "pong")

- the ping timer is not reset after upgrade on the client-side, so an
upgrade which took longer than the `pingTimeout` duration could lead to
a "ping timeout" error on the client-side

I think the latter issue is present since the initial implementation.

Related: socketio/socket.io-client-swift#1309 (comment)
    @darrachequesne
    darrachequesne committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    ff2b8ab View commit details
    Browse the repository at this point in the history

  2. chore: point towards the master branch for the CI badge 

    Reference: https://docs.github.com/en/actions/managing-workflow-runs/adding-a-workflow-status-badge#using-the-branch-parameter
    @darrachequesne
    darrachequesne committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    ae840fa View commit details
    Browse the repository at this point in the history

  3. chore(release): 4.1.1 

    Diff: 4.1.0...4.1.1
    @darrachequesne
    darrachequesne committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    9534355 View commit details
    Browse the repository at this point in the history
Loading