-
Notifications
You must be signed in to change notification settings - Fork 565
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: socketio/engine.io
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e7115b8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: socketio/engine.io
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c6315af
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 12 commits
- 24 files changed
- 2 contributors
Commits on Dec 30, 2020
-
docs(changelog): include changelog for release 3.5.0
Merged from the 3.5.x branch.
Configuration menu - View commit details
-
Copy full SHA for 04ea358 - Browse repository at this point
Copy the full SHA 04ea358View commit details -
Configuration menu - View commit details
-
Copy full SHA for cec2750 - Browse repository at this point
Copy the full SHA cec2750View commit details -
Configuration menu - View commit details
-
Copy full SHA for fffa0a3 - Browse repository at this point
Copy the full SHA fffa0a3View commit details
Commits on Jan 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5a91253 - Browse repository at this point
Copy the full SHA 5a91253View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b62152 - Browse repository at this point
Copy the full SHA 9b62152View commit details
Commits on Jan 14, 2021
-
feat: add support for v3.x clients
In order to ease the migration to Socket.IO v3, the Engine.IO server can now communicate with v3.x clients. ```js const eioServer = require("engine.io")(httpServer, { allowEIO3: true // false by default }); ``` If `allowEIO3` is false, the v3.x clients will now receive an HTTP 400 response ("Unsupported protocol version"). Note: the code of the v3 parser has been imported from [1] and browser-related dependencies were removed. [1]: https://github.com/socketio/engine.io-parser/tree/2.2.1 Related: - socketio/engine.io-protocol#35 - socketio/socket.io-protocol#21
Configuration menu - View commit details
-
Copy full SHA for 663d326 - Browse repository at this point
Copy the full SHA 663d326View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5b307c - Browse repository at this point
Copy the full SHA e5b307cView commit details
Commits on Feb 2, 2021
-
fix: do not reset the ping timer after upgrade
There was two issues with this behavior: - v3 clients (with allowEIO3: true) were also receiving a "ping" after a successful upgrade, which is incorrect (in v3, it's the client that sends the "ping", and the server answers with a "pong") - the ping timer is not reset after upgrade on the client-side, so an upgrade which took longer than the `pingTimeout` duration could lead to a "ping timeout" error on the client-side I think the latter issue is present since the initial implementation. Related: socketio/socket.io-client-swift#1309 (comment)
Configuration menu - View commit details
-
Copy full SHA for ff2b8ab - Browse repository at this point
Copy the full SHA ff2b8abView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae840fa - Browse repository at this point
Copy the full SHA ae840faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9534355 - Browse repository at this point
Copy the full SHA 9534355View commit details
Commits on Jan 11, 2022
-
fix: properly handle invalid data sent by a malicious websocket client
**IMPORTANT SECURITY FIX** A malicious client could send a specially crafted HTTP request, triggering an uncaught exception and killing the Node.js process: > RangeError: Invalid WebSocket frame: RSV2 and RSV3 must be clear > at Receiver.getInfo (/.../node_modules/ws/lib/receiver.js:176:14) > at Receiver.startLoop (/.../node_modules/ws/lib/receiver.js:136:22) > at Receiver._write (/.../node_modules/ws/lib/receiver.js:83:10) > at writeOrBuffer (internal/streams/writable.js:358:12) This bug was introduced by [1], included in `[email protected]`, so previous releases are not impacted. [1]: f3c291f Thanks to Marcus Wejderot from Mevisio for the responsible disclosure. Backported from master: c0e194d
Configuration menu - View commit details
-
Copy full SHA for a70800d - Browse repository at this point
Copy the full SHA a70800dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6315af - Browse repository at this point
Copy the full SHA c6315afView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff e7115b8...c6315af