Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: socketio/socket.io-client-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: socket.io-client-2.1.0
Choose a base ref
...
head repository: socketio/socket.io-client-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: socket.io-client-2.1.1
Choose a head ref
  • 7 commits
  • 7 files changed
  • 3 contributors

Commits on Jul 10, 2022

  1. Configuration menu
    Copy the full SHA
    17d13c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    22518c9 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Configuration menu
    Copy the full SHA
    ad3a930 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Configuration menu
    Copy the full SHA
    774543e View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. fix: make sendBuffer thread safe (#769)

    Clearing the buffer upon timeout could lead to:
    
    ```
    java.util.ConcurrentModificationException
    	at java.base/java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:970)
    	at java.base/java.util.LinkedList$ListItr.next(LinkedList.java:892)
    	at io.socket.client.Socket$6$1.run(Socket.java:232)
    	at java.base/java.util.TimerThread.mainLoop(Timer.java:556)
    	at java.base/java.util.TimerThread.run(Timer.java:506)
    ```
    
    Related:
    
    - #710
    - #727
    - #758
    - #759
    Harsh5488 authored Jul 10, 2024
    Configuration menu
    Copy the full SHA
    b00ae8e View commit details
    Browse the repository at this point in the history
  2. fix: discard acknowledgements upon disconnection

    Previously, getting disconnected while waiting for an acknowledgement
    would create a memory leak, as the acknowledgement was never received
    and the handler would stay in memory forever.
    
    See also: socketio/socket.io-client@34cbfbb
    
    Related: #446
    darrachequesne committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    54645ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e11f2f View commit details
    Browse the repository at this point in the history
Loading