Add support for Kotlin Gradle projects #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, running `lsif-java index` in a Gradle project only indexed Java and Scala sources. Now, we also index Kotlin sources.
|
I have no idea what I did to make this work, so this is a nice surprise
|
|
@Strum355 kudos to the Kotlin compiler team for designing it in a way you don't have to know why that works! |
Strum355
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running
lsif-java indexin a Gradle project only indexedJava and Scala sources. Now, we also index Kotlin sources.
Besides the automated tests in this PR, this change was manually validated on the kotest/kotest repo which is a large-ish (1.2k Kotlin sources) multiplatform project that you can browse with precise code intel here https://sourcegraph.com/github.com/kotest/kotest@7ccb6ef/-/blob/kotest-common/src/jvmMain/kotlin/io/kotest/common/platform.kt?L3:22#tab=references
Fixes #339