FIX: Library does not work with small (2-16Kbits) eeprom devices #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For memory chips smaller than 16kbits you need to send only 1 packet (8bits) of adress via I2C. This fix checkes for defined memory size and based on this either sends 16bit adress or 8bit address.
|
Nice fix. Nice first PR. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For memory chips smaller than 16kbits you need to send only 1 packet (8bits) of adress via I2C.
This fix checkes for defined memory size and based on this either sends 16bit adress or 8bit address.
Tested on 2Kbits EEPROM: HT24LC02