Skip to content

Commit 6826bdd

Browse files
committed
Document disabled test for hybrid annotation attribute overrides
This commit documents the @ignore'd test to explain that Spring does not support a hybrid approach for annotation attribute overrides with transitive implicit aliases. Issue: SPR-13554
1 parent f6cb30b commit 6826bdd

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

spring-core/src/test/java/org/springframework/core/annotation/AnnotatedElementUtilsTests.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,15 @@ public void getMergedAnnotationAttributesWithConventionBasedComposedAnnotation()
308308
assertTrue(isAnnotated(element, name));
309309
}
310310

311-
@Ignore("Disabled until SPR-13554 is addressed")
311+
/**
312+
* This test should never pass, simply because Spring does not support a hybrid
313+
* approach for annotation attribute overrides with transitive implicit aliases.
314+
* See SPR-13554 for details.
315+
* <p>Furthermore, if you choose to execute this test, it can fail for either
316+
* the first test class or the second one (with different exceptions), depending
317+
* on the order in which the JVM returns the attribute methods via reflection.
318+
*/
319+
@Ignore("Permanently disabled but left in place for illustrative purposes")
312320
@Test
313321
public void getMergedAnnotationAttributesWithHalfConventionBasedAndHalfAliasedComposedAnnotation() {
314322
for (Class<?> clazz : asList(HalfConventionBasedAndHalfAliasedComposedContextConfigClassV1.class,
@@ -860,6 +868,10 @@ static class MetaCycleAnnotatedClass {
860868
String[] locations();
861869
}
862870

871+
/**
872+
* This hybrid approach for annotation attribute overrides with transitive implicit
873+
* aliases is unsupported. See SPR-13554 for details.
874+
*/
863875
@ContextConfig
864876
@Retention(RetentionPolicy.RUNTIME)
865877
@interface HalfConventionBasedAndHalfAliasedComposedContextConfig {

0 commit comments

Comments
 (0)