Spring MVC REST: Support for binding Google Protocol Buffers messages [SPR-6259]

[spring-projects-issues]

Alex Antonov opened SPR-6259 and commented

Provide facility to support binding for Google Protocol Buffers messages to MVC Controller method arguments.

Code implementation to follow.

---

Affects: 3.0 RC1

Attachments:

• ContentType.java (1.07 kB)
• ExtensionRegistryInitializer.java (375 bytes)
• ProtobufAnnotationMethodHandlerAdapter.java (2.13 kB)
• ProtobufServletRequestDataBinder.java (3.39 kB)
• Utils.java (5.69 kB)

Issue Links:

• Spring REST @MVC: Add support for google Protocol Buffers resource representation format [SPR-5807] #10477 Spring REST @MVC: Add support for google Protocol Buffers resource representation format ("supersedes")

Referenced from: commits b56703e

2 votes, 7 watchers

[spring-projects-issues]

Alex Antonov commented

Dependency files to the ProtobufServletRequestDataBinder

[spring-projects-issues]

Alex Antonov commented

This databinder assumes that if you are trying to bind a Message instance, the entire HTTP request (GET, PUT, POST or DELETE) would be the protobuf payload.
In case of PUT/POST the request.getInputStream is used, for GET/DELETE a Base64 encoded content of the parameter-less query string.

This has been tested and used with Spring/Spring MVC 2.5.2 (seems to be behaving a bit differently in version 2.5.6 due to the changes in AnnotationMethodHandlerAdapter and ServletHandlerMethodInvoker)

[spring-projects-issues]

Tom Ziemer commented

Are there plans to incorporate this into Spring4?

[spring-projects-issues]

Rossen Stoyanchev commented

This is related to #10477, which is already scheduled for 4.1 RC1 so I'm adding this as well for consideration at the same time.

[spring-projects-issues]

Rossen Stoyanchev commented

As for 4.1 the present thinking is that the best fit for GPB support is an HttpMessageConverter. A pull request has been submitted under #10477 and is being processed. Therefore this ticket can be closed and is superseded.