When using HttpComponentsClientHttpRequestFactory, setting a proxy through RequestConfig should not be ignored [SPR-12335]

[spring-projects-issues]

Olivier Orand opened SPR-12335 and commented

Hi,
When using httpComponentsClientHttpRequestFactory, setting a proxy through RequestConfig is ignored.
But when this requestConfig is used by HttpClient, it isn't ignored.
It seems to be a "wiring" issue between Spring and HttpClient.
As workaround, setting a custom route planner can be use. Maybe there is a better workaround.

The maven project demonstrates a working case with HttpClient and failure with RestTemplate and with httpComponentsClientHttpRequestFactory.
Test project start an in memory proxy, and try to access a url resolvable only using proxy.

Regards,
Olivier

---

Affects: 4.0.5, 4.1.1

Reference URL: https://github.com/Orange-OpenSource/spring-http-proxy-testcase

Issue Links:

• Configured RequestConfig in HttpClient gets overwritten by default [SPR-12540] #17144 Configured RequestConfig in HttpClient gets overwritten by default ("is duplicated by")
• Upgrade HttpComponentsHttpInvokerRequestExecutor to require Apache HttpComponents 4.3 [SPR-11113] #15739 Upgrade HttpComponentsHttpInvokerRequestExecutor to require Apache HttpComponents 4.3

1 votes, 5 watchers

[spring-projects-issues]

Juergen Hoeller commented

Stéphane Nicoll, along with #15739, let's have a look at this one for 4.1.4 still...

Juergen

[spring-projects-issues]

Stéphane Nicoll commented

Thanks a lot for the project Olivier! This is strongly related to #17144 actually and with the current proposal your tests run fine against it (except a wrong assertion that should use an HttpStatus and not a raw code). I'll make sure to run your project against master once the proposal has been merged to make sure this issue is resolved as well.

[spring-projects-issues]

Stéphane Nicoll commented

This was fixed as part of #17144

[spring-projects-issues]

Olivier Orand commented

Hi Stéphane,
Great, thanks for the fix.

Olivier