Skip to content

Improve diagnostics when a Bean Override cannot be selected by type #34004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sbrannen opened this issue Dec 2, 2024 · 1 comment
Closed

Improve diagnostics when a Bean Override cannot be selected by type #34004

sbrannen opened this issue Dec 2, 2024 · 1 comment
Labels
in: test Issues in the test module type: enhancement A general enhancement

Comments

@sbrannen
Copy link
Member

sbrannen commented Dec 2, 2024 •
edited
Loading

Overview

Whenever a bean override (such as for @TestBean, @MockitoBean, and @MockitoSpyBean) cannot be selected "by type", we should improve diagnostics for users by pointing out (in the exception's message) that the type selection might have failed because the runtime type of the target bean could not be inferred.

Related Issues
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Dec 2, 2024
@sbrannen sbrannen added this to the 6.2.x milestone Dec 2, 2024
@sbrannen sbrannen mentioned this issue Dec 2, 2024
Closed
@sbrannen sbrannen changed the title Improve exception message when a Bean Override cannot be selected by type Improve diagnostics when a Bean Override cannot be selected by type Dec 2, 2024
quaff added a commit to quaff/spring-framework that referenced this issue Dec 3, 2024
@quaff
Improve diagnostics when a Bean Override cannot be selected by type
3654338 
Close spring-projectsGH-34004
@quaff quaff mentioned this issue Dec 3, 2024
Closed
@sbrannen
Copy link
Member Author

sbrannen commented Feb 8, 2025

@sbrannen sbrannen closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2025
@sbrannen sbrannen removed this from the 6.2.x milestone Feb 8, 2025
quaff added a commit to quaff/spring-framework that referenced this issue Feb 10, 2025
@quaff
Improve diagnostics when a Bean Override cannot be selected by type
c6fa286 
Close spring-projectsGH-34004

Signed-off-by: Yanming Zhou <[email protected]>
quaff added a commit to quaff/spring-framework that referenced this issue Feb 10, 2025
@quaff
Improve diagnostics when a Bean Override cannot be selected by type
e89dfbe 
Close spring-projectsGH-34004

Signed-off-by: Yanming Zhou <[email protected]>
sbrannen pushed a commit to sbrannen/spring-framework that referenced this issue Feb 10, 2025
@quaff @sbrannen
Improve diagnostics when a Bean Override cannot be selected by type
cf46f39 
See spring-projectsgh-34004
Closes spring-projectsgh-34006

Signed-off-by: Yanming Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve diagnostics when a Bean Override cannot be selected by type quaff/spring-framework
1 participant
@sbrannen