Skip to content

Predicate for field runtime hints should not have an explicit invoke option #34294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Jan 21, 2025 · 1 comment
Closed

Predicate for field runtime hints should not have an explicit invoke option #34294

snicoll opened this issue Jan 21, 2025 · 1 comment
Assignees
@bclozel @snicoll
Labels
type: task A general task
Milestone
7.0.0-M1

Comments

@snicoll
Copy link
Member

snicoll commented Jan 21, 2025

Looking at the changes for the new GraalVM format, FieldHintPredicate is no longer valid as it doesn't take field names into account. Also field hints always intended invocation (getting/setting the value of the field.
@snicoll snicoll added the type: task A general task label Jan 21, 2025
@snicoll snicoll added this to the 7.0.0-M1 milestone Jan 21, 2025
@snicoll snicoll self-assigned this Jan 21, 2025
@bclozel
Copy link
Member

bclozel commented Jan 21, 2025

Also, the TypeHint API is not aligned with the recent changes and still promotes reflection-only hints.

@bclozel bclozel modified the milestones: 7.0.0-M1, 6.2.3 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bclozel bclozel

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
7.0.0-M1
Development

No branches or pull requests
2 participants
@bclozel @snicoll