Give SecurityFilterChain a name for tracing!

[zidom]

Give SecurityFilterChain a name for debug tracing!

[rwinch]

I do not understand the request. Can you please provide more details.

[zidom]

When there are multipleSecurityFilterChain, eachSecurityFilterChain has multiple filters, and these filters are the same or similar in most cases, during the development period, it is difficult to determine which SecurityFilterChain the request is, it is easy to confuse! Therefore, whether you can give the SecurityFilterChain a name, in the debug log with the corresponding name, I think this is very helpful for debugging and monitoring!

[rwinch]

This sounds like a reasonable idea. I think we can use the beanName which is injected using BeanNameAware interface. Would you be interested in submitting a PR?

[ankurpathak]

@rwinch > This sounds like a reasonable idea. I think we can use the beanName which is injected using BeanNameAware interface. Would you be interested in submitting a PR?

I have implemented BeanNameAware in DefaultSecurityFilterChain. but it won't be helping much
because I think Spring doesn't register instances of it as Bean in BeanFactory. I debugged it after
using artifacts with these changes and was getting the Bean Name as null in DefaultSecurityFilterChain.

Here is pull reuest with above changes:
#6288

[rwinch]

@ankurpathak I thought the request was for creating multiple FilterChainProxy instances.

I think at this point we need to understand exactly what we are looking for before we go further.

What exactly is being looked for here? The toString of DefaultSecurityFilterChain already includes the RequestMatcher used which in most cases should help the user know which one is being used.

[ankurpathak]

@rwinch Please take a look at this scrrenshot its using Spring Boot 1.5 with Old Spring OAuth 2 Project.
It has four Spring Security Chains. The First two has Request Macher which has some path with them
so can be used in logging and Second two(created For OAuth created automatically) have Request Matcher have no path with them so can not be used in logging. So I thing name for them will help a lot.

[rwinch]

I think we could add a id property to the request matcher that is then reflected in the toString. This ensures that we don't need to do instanceof checks on the DefaultSecurityFilterChain

[ankurpathak]

@rwinch I think its a good idea as it will work with individual flters using RequestMatcher or any thing
else using Request Matcher. I have done changes in below pull request to accomodated it.
#6308
Let me know if it requires any modifications or changes.