-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Deprecate OpenID 2.0 Support #7153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @rwinch, do you think this is good for |
Hey @eddumelendez Thanks for the question. I think this is a lot of files to touch for a first timers issue. |
Hi @rwinch, I would be available to take this issue. |
Thanks @ThomasVitale! The issue is yours if you still want it |
I will start working on it then, thanks @rwinch |
@ThomasVitale by any chance if you didn't get time to work on this, can I take this issue? |
Hi @farooqkhan003, I have started with it and then didn't have time to complete it. So far I have added the deprecation notice to all files in the openid module. Would you like to take over and complete the remaining parts of the task? If so, @rwinch can we split the delivery in 2 parts or should it be a single one? In any case, I have created a PR with the changes I have done so far. |
@farooqkhan003 Are you still working on this issue? If not, @rwinch can I take it? |
@dadikovi unfortunately I didn't get chance to work on this issue. |
@dadikovi Please take it. The issue is yours |
@rwinch Thanks. I sent in a draft PR. I'm not sure if in case of XML configuration should I write the deprecation notice more formally (eg. in a dedicated tag), or is this okay that I put it in the documentation tag. Please note that this PR will introduce the deprication notice only in docs, sample applications and configurations. Earlier PR (#7554) contained the notice for all files in related packages. Should I merge these two together, or is it okay this way? |
This commit puts deprecation notice on docs, sample applications and configurations (java and xml) Fixes spring-projectsgh-7153
This commit adds link to spring code on the top of ThomasVitale's changes. Fixes spring-projectsgh-7153
This commit adds deprecation notice to xml schema, parser of the schema and removes fixme comments. Fixes spring-projectsgh-7153
Closing in favor of gh-8450 |
Uh oh!
There was an error while loading. Please reload this page.
Summary
The OpenID 1.0 and 2.0 protocols have been deprecated and users are encouraged to migrate to OpenID Connect. The openid4java library that is used by Spring Security has not seen an update since 2015 (4 years). We need to deprecate the OpenID support.
We should add the following deprecation notice:
To the following locations:
NOTE: We are NOT deprecating OpenID Connect support. Only the support for OpenID 2.0 protocol will be deprecated (the protocol itself was deprecated).
The text was updated successfully, but these errors were encountered: