Skip to content

OAuth2AuthorizeRequest supports attributes #7341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Sep 3, 2019 · 0 comments
Closed

OAuth2AuthorizeRequest supports attributes #7341

jgrandja opened this issue Sep 3, 2019 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.2.0.RC1

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Sep 3, 2019 •
edited
Loading

We should add a member to OAuth2AuthorizeRequest of type Map<String, Object> that can be used for request attributes.

In addition to this change, we should remove the HttpServletRequest and HttpServletResponse members from OAuth2AuthorizeRequest and instead populate these into the request attributes member.

This will also allow us to reuse OAuth2AuthorizeRequest as input to ServerOAuth2AuthorizedClientManager.authorize() and remove ServerOAuth2AuthorizeRequest.
@jgrandja jgrandja self-assigned this Sep 3, 2019
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels Sep 3, 2019
@jgrandja jgrandja added this to the 5.2.0.RC1 milestone Sep 3, 2019
jgrandja added a commit to jgrandja/spring-security that referenced this issue Sep 4, 2019
@jgrandja
OAuth2AuthorizeRequest supports attributes
f75b51e 
Fixes spring-projectsgh-7341
@jgrandja jgrandja mentioned this issue Sep 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.RC1
Development

Successfully merging a pull request may close this issue.

OAuth2AuthorizeRequest supports attributes jgrandja/spring-security
1 participant
@jgrandja