Skip to content

OpenSamlImplementation should not use reflection #8147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Mar 18, 2020 · 0 comments
Closed

OpenSamlImplementation should not use reflection #8147

jzheaux opened this issue Mar 18, 2020 · 0 comments
Assignees
@jzheaux
Labels
in: saml2 An issue in SAML2 modules status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Milestone
5.4.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Mar 18, 2020

It would be better if OpenSamlImplementation didn't use reflection.

OpenSamlImplementation#buildSAMLObject(Class<?>) uses reflection to discover how to construct an object of the provided type, but it could simply take a QName and achieve the same end without reflecting, e.g. buildSamlObject(QName).
@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Mar 18, 2020
@jzheaux jzheaux added this to the 5.4.0.M1 milestone Mar 18, 2020
@jzheaux jzheaux self-assigned this Mar 18, 2020
jzheaux added a commit that referenced this issue Mar 20, 2020
@jzheaux
Simplify OpenSamlImplementation
15cc15c 
- Removed reflection usage
- Simplified method signatures

Issue gh-7711
Fixes gh-8147
@spring-projects-issues spring-projects-issues added the status: backported An issue that has been backported to maintenance branches label Mar 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules status: backported An issue that has been backported to maintenance branches type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M1
Development

No branches or pull requests
2 participants
@jzheaux @spring-projects-issues