Skip to content

Missing Reactive SwitchUserWebFilter for user impersonation #8599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aotrzonsek opened this issue May 27, 2020 · 3 comments
Closed

Missing Reactive SwitchUserWebFilter for user impersonation #8599

aotrzonsek opened this issue May 27, 2020 · 3 comments
Assignees
@aotrzonsek
Labels
in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Milestone
5.4.0-RC1

Comments

@aotrzonsek
Copy link

Expected Behavior

Add the possibility to impersonate a user in Reactive applications as it is possible by using the SwitchUserFilter.

Current Behavior

It is not possible to switch the user context, at least I couldn't find anything equivalent.

Context

It’s a common use-case that some admin users should be able to log in as any other user.
In our applications we have used this feature for customer support analysis where the analyst can access the system as the real user.
@aotrzonsek aotrzonsek added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels May 27, 2020
@rwinch
Copy link
Member

rwinch commented May 28, 2020

Thanks for the report @aotrzonsek Would you be interested in submitting a pull request?

@rwinch rwinch added in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels May 28, 2020
@aotrzonsek
Copy link
Author

Sure why not, I have to implement it anyway. I will add a comment after I have finished the implementation.

@aotrzonsek aotrzonsek mentioned this issue Jun 12, 2020
Closed
@aotrzonsek
Copy link
Author

All issues found during the code review have been removed.

aotrzonsek pushed a commit to aotrzonsek/spring-security that referenced this issue Jul 22, 2020
Reactive SwitchUserWebFilter for user impersonation
98b472b 
Before:
It was not possible to switch the user context by using Spring WebFlux Security

After:
Added an appropriate filter that allows switch the user context in Spring WebFlux Security

Closes spring-projectsgh-8599
@eleftherias eleftherias added this to the 5.4.0-RC1 milestone Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aotrzonsek aotrzonsek

Labels
in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-RC1
Development

Successfully merging a pull request may close this issue.

Reactive SwitchUserWebFilter for user impersonation aotrzonsek/spring-security
3 participants
@rwinch @eleftherias @aotrzonsek