Skip to content

Add username as an option for SearchFilter #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kirktarou
Copy link

Currently, search filter substitutions are limited only to the bindPrincipal (username@domain).
'username' value will be substituted with {1}

Currently, search filter substitutions are limited only to the bindPrincipal (username@domain).
'username' value will be substituted with {1}
@aabeling
Copy link

aabeling commented Jun 1, 2016

This seems to be a solution for #3303

@pivotal-issuemaster
Copy link

@Kirkalicious Please sign the Contributor License Agreement!

@pivotal-issuemaster
Copy link

@Kirkalicious Thank you for signing the Contributor License Agreement!

@pivotal-issuemaster
Copy link

@Kirkalicious Thank you for signing the Contributor License Agreement!

@rwinch rwinch modified the milestone: 4.2.0 M1 Aug 15, 2016
@jgrandja jgrandja self-assigned this Aug 31, 2016
@jgrandja
Copy link
Contributor

@Kirkalicious Thanks for submitting this PR. The search filter substitution for {1} won't take effect based on your changes as the default searchFilter in ActiveDirectoryLdapAuthenticationProvider is set at

(&(objectClass=user)(userPrincipalName={0}))

We also need tests added for this change. After you update the PR I'll merge this.

Thank you.

@jgrandja jgrandja added the status: waiting-for-feedback We need additional information before we can continue label Aug 31, 2016
@jgrandja
Copy link
Contributor

Related to #3950

@jgrandja
Copy link
Contributor

Thanks for submitting this PR @Kirkalicious.

We are currently re-thinking our approach to an Active Directory AuthenticationProvider implementation. Our direction is to deprecate ActiveDirectoryLdapAuthenticationProvider and leverage the existing LdapAuthenticationProvider and provide a custom strategy of LdapAuthenticator for Active Directory.

The work has already started in #4064 if you would like to track the progress and provide any input/feedback.

I'm going to close this PR as we will address your input/feedback in #4064.
Thank you.

@jgrandja jgrandja closed this Sep 19, 2016
@jgrandja jgrandja added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 19, 2016
@jgrandja jgrandja removed this from the 4.2.0 M1 milestone Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants