Allow using username in Active Directory LDAP search filter

[zhoppy1]

When customizing the LDAP search filter used by ActiveDirectoryLdapAuthenticationProvider I have a need to reference just the username. The default {0} is username@domain. This small change will allow filters to reference the username with {1}

Example:

userPrincipalName = [email protected]
sAMAccountName = someUser
Domain Name: foo

Trying to set the filter to use sAMAccountName instead of userPrincipalName results in the domain name being included.

provider.setSearchFilter("(&(objectClass=user)(sAMAccountName={0}))");

Results in (&(objectClass=user)([email protected]))

This code change will let me use {1} in the filter instead so the search will be: (&(objectClass=user)(sAMAccountName=someUser))

I was unable to simply extend ActiveDirectoryLdapAuthenticationProvider because it is marked final.

[pivotal-issuemaster]

@zhoppy1 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[jgrandja]

Related to #249

[jgrandja]

Thanks for submitting this PR @zhoppy1.

We are currently re-thinking our approach to an Active Directory AuthenticationProvider implementation. Our direction is to deprecate ActiveDirectoryLdapAuthenticationProvider and leverage the existing LdapAuthenticationProvider and provide a custom strategy of LdapAuthenticator for Active Directory.

The work has already started in #4064 if you would like to track the progress and provide any input/feedback.

I'm going to close this PR as we will address your input/feedback in #4064.
Thank you.