Add Active Directory implementation of LdapAuthenticator #4064
Conversation
The intention of this update is to replace/deprecate ActiveDirectoryLdapAuthenticationProvider with this new implementation of a Active Directory specific LdapAuthenticator.
|
Any news on this? BTW, there could be problems with the DefaultAuthenticationPrincipalDecorator when there are trusted domains and the principal's domain != domainFromBaseDN. |
There was a problem hiding this comment.
There could be problems with the DefaultAuthenticationPrincipalDecorator when there are trusted domains and the principal's domain != domainFromBaseDN.
example:
prinicipal="[email protected]"
basedomain="domainB.com"
| } | ||
|
|
||
| public final void setManagerDn(String managerDn) { | ||
| Assert.notNull(managerDn, "managerDn is null"); |
There was a problem hiding this comment.
I think that yo could validate for non empty string also: StringUtils.hasText
| } | ||
|
|
||
| public final void setSearchBase(String searchBase) { | ||
| Assert.notNull(searchBase, "searchBase is null"); |
There was a problem hiding this comment.
I think that yo could validate for non empty string also: StringUtils.hasText
| } | ||
|
|
||
| public final void setManagerPassword(String managerPassword) { | ||
| Assert.notNull(managerPassword, "managerPassword is null"); |
There was a problem hiding this comment.
I think that yo could validate for non empty string also: StringUtils.hasText
| } | ||
|
|
||
| public final void setSearchFilter(String searchFilter) { | ||
| Assert.notNull(searchFilter, "searchFilter is null"); |
There was a problem hiding this comment.
I think that yo could validate for non empty string also: StringUtils.hasText
| } | ||
|
|
||
| public final void setPasswordAttributeName(String passwordAttributeName) { | ||
| Assert.notNull(passwordAttributeName, "passwordAttributeName is null"); |
There was a problem hiding this comment.
I think that yo could validate for non empty string also: StringUtils.hasText
| } | ||
|
|
||
| public final void setPasswordEncoder(PasswordEncoder passwordEncoder) { | ||
| Assert.notNull(passwordEncoder, "passwordEncoder is null"); |
There was a problem hiding this comment.
I think that yo could validate for non empty string also: StringUtils.hasText
|
@steigerm @vborcea Thank you for all the feedback! |
|
Too bad. |
0e114c6 to
fd244eb
Compare
|
Closing this PR as it's quite old and may need further updates. I'll submit a new PR when I get a chance to revisit this and apply the necessary changes. |
The intention of this update is to replace/deprecate
ActiveDirectoryLdapAuthenticationProviderwith this new implementationof a Active Directory specific
LdapAuthenticator.Related to #3950, #3933, #249, #246, #74, #2390