Add Support for Clear Site Data on Logout #6550
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
requested changes
Feb 22, 2019
...ringframework/security/config/annotation/web/configurers/HeaderWriterLogoutHandlerTests.java
Outdated
Show resolved
Hide resolved
...ringframework/security/config/annotation/web/configurers/HeaderWriterLogoutHandlerTests.java
Outdated
Show resolved
Hide resolved
...ringframework/security/config/annotation/web/configurers/HeaderWriterLogoutHandlerTests.java
Outdated
Show resolved
Hide resolved
...ringframework/security/config/annotation/web/configurers/HeaderWriterLogoutHandlerTests.java
Outdated
Show resolved
Hide resolved
...ringframework/security/config/annotation/web/configurers/HeaderWriterLogoutHandlerTests.java
Outdated
Show resolved
Hide resolved
...n/java/org/springframework/security/web/authentication/logout/HeaderWriterLogoutHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/web/header/writers/ClearSiteDataHeaderWriter.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/web/header/writers/ClearSiteDataHeaderWriter.java
Show resolved
Hide resolved
|
|
||
| private final Log logger = LogFactory.getLog(getClass()); | ||
|
|
||
| private RequestMatcher requestMatcher; |
There was a problem hiding this comment.
Will you please make these fields final?
...n/java/org/springframework/security/web/authentication/logout/HeaderWriterLogoutHandler.java
Outdated
Show resolved
Hide resolved
Added an implementation of HeaderWriter for Clear-Site-Data HTTP response header as welll as an implementation of LogoutHanlder that accepts an implementation of HeaderWriter to write headers. - Added ClearSiteDataHeaderWriter and HeaderWriterLogoutHandler that implements HeaderWriter and LogoutHandler respectively - Added unit tests for both implementations's behaviours - Integration tests for HeaderWriterLogoutHandler that uses ClearSiteDataHeaderWriter - Updated the documentation to include link to HeaderWriterLogoutHandler Fixes spring-projectsgh-4187
jzheaux
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Clear Site Data HTTP response header. See the issue for more details.
Fixes #4187