Add constructor to JwtAuthenticationToken that takes a principal name #6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzheaux
requested changes
May 21, 2019
There was a problem hiding this comment.
Hey, great job, thank you for the PR, @HaydenMeloche!
I've left some feedback inline.
...g/springframework/security/oauth2/server/resource/authentication/JwtAuthenticationToken.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/oauth2/server/resource/authentication/JwtAuthenticationToken.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/oauth2/server/resource/authentication/JwtAuthenticationToken.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/oauth2/server/resource/authentication/JwtAuthenticationToken.java
Outdated
Show resolved
Hide resolved
...g/springframework/security/oauth2/server/resource/authentication/JwtAuthenticationToken.java
Show resolved
Hide resolved
...ingframework/security/oauth2/server/resource/authentication/JwtAuthenticationTokenTests.java
Show resolved
Hide resolved
bb79f1b to
5f1ec2a
Compare
|
@jzheaux Thanks for your review, I believe I made all the changes you requested. Can you take another look? 😄 |
5f1ec2a to
d86eec8
Compare
jzheaux
added a commit
that referenced
this pull request
May 23, 2019
Aligned JavaDoc and added tests to better assess getName's functionality. Issue: gh-6893
jzheaux
added a commit
that referenced
this pull request
May 23, 2019
Using Jwt.Builder to clean up some of this test's config. Issue: gh-6893
|
Thanks for the PR, @HaydenMeloche! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6865
I added two constructors to allow a custom principal name to be passed to the class. Otherwise the constructor will just set the name value to be token's subject.