Add RequestRejectedHandler

[leonard84]

…uests

Fixes gh-5007

[pivotal-issuemaster]

@leonard84 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[leonard84]

@rwinch the company cla is currently at our legal department, but you can review the pr already.

[rwinch]

Thanks for the PR @leonard84! I provided feedback inline.

Can you please update the documentation to include this new feature?

Another thing to consider is that we need support for XML based users. I'd really appreciate if the ticket includes this support. However, if you are unable to contribute XML namespace support, please create a ticket instead.

[leonard84]

@rwinch I had some open questions in the issue:

• FilterChainProxy is configured in WebSecurity, but the ExceptionHandlingConfigurer lives in a different package, so the getRequestRejectedHandler() would have to be public. Would it make more sense to make it a property of WebSecurity?
• Travis seems to have removed Oracle Java 8 support

$ ~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"
install-jdk.sh 2019-06-25
Expected feature release number in range of 9 to 14, but got: 8
The command "~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL"" failed and exited with 3 during .

[leonard84]

@rwinch friendly ping, see above

[rwinch]

Thanks for the ping.

I'd say we should just expose the handler via a Bean lookup similar to how httpFirewall is looked up in WebSecurity.

I'm not sure what is happening with the JDK. Our travis build is passing with JDK 8. How did you reproduce this?

[rwinch]

FYI it appears the Travis build was related to gh-7169 which has been resolved

[pivotal-issuemaster]

@leonard84 Thank you for signing the Contributor License Agreement!

[leonard84]

@rwinch please take another look

[rwinch]

Thanks for the ping. I've provided some more feedback inline.

[rwinch]

Thanks for the updates and ping @leonard84! I have provided additional feedback inline

[leonard84]

@rwinch I've implemented your requests

[leonard84]

@rwinch ping

[leonard84]

@rwinch ping again

[leonard84]

@rwinch I've rebased to fix the merge problems and squashed the commits into one

[skjolber]

@rwinch ping

[ptahchiev]

Ping again - this is a much needed feature :)

[patrykks]

Any update in this thread? This is really needed by community.

[rwinch]

I've provided feedback inline. Also please update tests to be Java based as we don't use Groovy for tests anymore. Finally, please make sure you rebase off the current master.

[leonard84]

@rwinch I've rebased and converted the Spock tests to the old JUnit 4 style and removed the cglib dependency as byte-buddy is now used to proxy classes.
Out of interest, what was the reason for the removal of Spock/groovy for testing?

[rwinch]

Thanks for the PR @leonard84! This is now merged into master. I've added a bit of polish 0483b3e and support for configuring via XML 4a9fa03.

Out of interest, what was the reason for the removal of Spock/groovy for testing?

As a Java project, testing in Groovy made an unnecessary hurtle for contributors. We switched to make contributions easier for our audience.