Skip to content

Commit 0abbba0

Browse files
author
Rob Winch
committed
Polish Generics and Update Spring Version
We needed to update Spring Version to avoid https://jira.spring.io/browse/SPR-11471
1 parent 6130a10 commit 0abbba0

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

README.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ public class Config {
203203
}
204204
205205
@Bean
206-
public SessionRepositoryFilter<RedisSession> sessionFilter(SessionRepository<RedisSession> sessionRepository) {
207-
return new SessionRepositoryFilter<RedisSession>(sessionRepository);
206+
public <S extends ExpiringSession> SessionRepositoryFilter<? extends ExpiringSession> sessionFilter(SessionRepository<S> sessionRepository) {
207+
return new SessionRepositoryFilter<S>(sessionRepository);
208208
}
209209
}
210210

gradle/java.gradle

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ group = 'org.springframework.session'
1111
ext.jstlVersion = '1.2.1'
1212
ext.servletApiVersion = '3.0.1'
1313
ext.springSecurityVersion = '3.2.4.RELEASE'
14-
ext.springVersion = '4.0.2.RELEASE'
14+
ext.springVersion = '4.1.0.RELEASE'
1515
ext.groovyVersion = '2.0.5'
1616
ext.seleniumVersion = '2.33.0'
1717
ext.spockVersion = '0.7-groovy-2.0'
@@ -40,6 +40,13 @@ repositories {
4040
maven { url 'http://clojars.org/repo' }
4141
}
4242

43+
configurations.all {
44+
resolutionStrategy.eachDependency { DependencyResolveDetails details ->
45+
if (details.requested.group == 'org.springframework') {
46+
details.useVersion springVersion
47+
}
48+
}
49+
}
4350
// Integration test setup
4451
configurations {
4552
integrationTestCompile {

samples/web/src/main/java/Config.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.springframework.session.ExpiringSession;
2626
import org.springframework.session.SessionRepository;
2727
import org.springframework.session.data.redis.RedisOperationsSessionRepository;
28-
import org.springframework.session.data.redis.RedisOperationsSessionRepository.RedisSession;
2928
import org.springframework.session.web.http.SessionRepositoryFilter;
3029

3130
import redis.clients.jedis.Protocol;
@@ -80,7 +79,7 @@ public RedisOperationsSessionRepository sessionRepository(RedisTemplate<String,
8079
}
8180

8281
@Bean
83-
public SessionRepositoryFilter<RedisSession> sessionFilter(SessionRepository<RedisSession> sessionRepository) {
84-
return new SessionRepositoryFilter<RedisSession>(sessionRepository);
82+
public <S extends ExpiringSession> SessionRepositoryFilter<? extends ExpiringSession> sessionFilter(SessionRepository<S> sessionRepository) {
83+
return new SessionRepositoryFilter<S>(sessionRepository);
8584
}
8685
}

spring-session/src/main/java/org/springframework/session/data/redis/RedisOperationsSessionRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ private BoundHashOperations<String, Object, Object> getSessionBoundHashOperation
233233
* @since 1.0
234234
* @author Rob Winch
235235
*/
236-
public final class RedisSession implements ExpiringSession {
236+
final class RedisSession implements ExpiringSession {
237237
private final MapSession cached;
238238
private Map<String, Object> delta = new HashMap<String,Object>();
239239

0 commit comments

Comments
 (0)