Add support for configuring default CookieSerializer
using SessionCookieConfig
#713
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #87.
The proposed solution doesn't map two attributes from
SessionCookieConfig
:secure
:DefaultCookieSerializer#useSecureCookie
defaults tonull
and relies onServletRequest#isSecure
which means mapping a value fromSessionCookieConfig
would override our default (sincesecure
is a primitiveboolean
over there and typically defaults tofalse
)httpOnly
:DefaultCookieSerializer#useHttpOnlyCookie
defaults totrue
in Servlet 3.0+ environments which means our default would be overridden inhttpOnly
typically defaults tofalse
Other than that integration tests in Boot based samples needed to be updated with explicitMockServletContext
due toMockSessionCookieConfig#maxAge
defaulting to0
instead of-1
. I've opened SPR-15142 to address that.