Skip to content

Typos: SwiftCompilerSources #75025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Typos: SwiftCompilerSources #75025

merged 1 commit into from
Aug 9, 2024

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Jul 7, 2024

Fix typos in SwiftCompilerSources

This is one batch of many PRs fixing typos, see the tracking issue.

@Sajjon Sajjon requested a review from eeckstein as a code owner July 7, 2024 13:16
@Sajjon Sajjon mentioned this pull request Jul 7, 2024
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise looks good.

Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please consider squashing post review commits at this stage. Although we can do that by selecting the merge strategy on GitHub when it is appropriate to squash the whole thing, code owners are not always mindful about this.

@Sajjon
Copy link
Contributor Author

Sajjon commented Aug 8, 2024

@AnthonyLatsis I've update to main branch, solve a merge conflict and squashed into a single commit. So re-review ready!

@AnthonyLatsis
Copy link
Collaborator

@swift-ci please smoke test

@AnthonyLatsis AnthonyLatsis self-assigned this Aug 9, 2024
@AnthonyLatsis AnthonyLatsis enabled auto-merge (squash) August 9, 2024 01:48
@AnthonyLatsis AnthonyLatsis merged commit c18a24e into swiftlang:main Aug 9, 2024
3 checks passed
@Sajjon Sajjon deleted the cyon_typo_batch__SwiftCompilerSources branch August 9, 2024 05:32
@AnthonyLatsis AnthonyLatsis removed their assignment Aug 13, 2024
@@ -112,7 +112,7 @@ private func extendAccessScopes(dependence: LifetimeDependence,
/// caller scope, which is handled separately). A nested 'read' access can never interfere with another access in the
/// same outer 'read', because it is impossible to nest a 'modify' access within a 'read'. For 'modify' accesses,
/// however, the inner scope must be extended for correctness. A 'modify' access can interfere with other 'modify'
/// accesss in the same scope. We rely on exclusivity diagnostics to report these interferences. For example:
/// access in the same scope. We rely on exclusivity diagnostics to report these interferences. For example:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the intended word here would have been "accesses."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants