-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Typos: SwiftCompilerSources
#75025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typos: SwiftCompilerSources
#75025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggestion, otherwise looks good.
SwiftCompilerSources/Sources/Optimizer/FunctionPasses/AsyncDemotion.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please consider squashing post review commits at this stage. Although we can do that by selecting the merge strategy on GitHub when it is appropriate to squash the whole thing, code owners are not always mindful about this.
@AnthonyLatsis I've update to main branch, solve a merge conflict and squashed into a single commit. So re-review ready! |
@swift-ci please smoke test |
@@ -112,7 +112,7 @@ private func extendAccessScopes(dependence: LifetimeDependence, | |||
/// caller scope, which is handled separately). A nested 'read' access can never interfere with another access in the | |||
/// same outer 'read', because it is impossible to nest a 'modify' access within a 'read'. For 'modify' accesses, | |||
/// however, the inner scope must be extended for correctness. A 'modify' access can interfere with other 'modify' | |||
/// accesss in the same scope. We rely on exclusivity diagnostics to report these interferences. For example: | |||
/// access in the same scope. We rely on exclusivity diagnostics to report these interferences. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intended word here would have been "accesses."
Fix typos in
SwiftCompilerSources
This is one batch of many PRs fixing typos, see the tracking issue.