Skip to content

[JsonPath] Add the component #20837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fabpot opened this issue Mar 28, 2025 · 10 comments · May be fixed by #20974
Open

[JsonPath] Add the component #20837

fabpot opened this issue Mar 28, 2025 · 10 comments · May be fixed by #20974
Labels
Milestone

Comments

@fabpot
Copy link
Member

fabpot commented Mar 28, 2025

Q A
Feature PR symfony/symfony#59655
PR author(s) @alexandre-daubois
Merged in 7.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.3 branch in the symfony-docs repository.

Thank you! 😃

@fabpot fabpot added this to the 7.3 milestone Mar 28, 2025
@RisingSunLight42
Copy link
Contributor

I just leaned about the component at Symfony Live, I'm going to look into it and if I feel confident enough I'll try to do the doc 😊
Would be my first contribution!

@alexandre-daubois
Copy link
Member

alexandre-daubois commented Mar 28, 2025

Thank you for your interest on this @RisingSunLight42. Feel free to ping me on the Symfony Slack if you need any information/support, I'll be happy to help 🙂

@xabbuh xabbuh added the JsonPath label Apr 3, 2025
@alexandre-daubois
Copy link
Member

Hello @RisingSunLight42, did you have time to check this issue? The component will be officially released at the end of May with Symfony 7.3, it would be nice to have the documentation ready (or almost ready) in the next few weeks 🙂

@RisingSunLight42
Copy link
Contributor

RisingSunLight42 commented Apr 14, 2025

Hi @alexandre-daubois! I started looking into it, as a warmup into writing doc for Symfony I was taking less time consuming issues before, but I'll work on it during the next weeks. I'll also open a draft PR so everyone can see how it's going.

@alexandre-daubois
Copy link
Member

Great news, thank you!

@GromNaN
Copy link
Member

GromNaN commented Apr 16, 2025

This should also cover the first and last methods introduced by symfony/symfony#60188.

@RisingSunLight42
Copy link
Contributor

This should also cover the first and last methods introduced by symfony/symfony#60188.

Noted, thank you!

@alexandre-daubois
Copy link
Member

Hi @RisingSunLight42, Symfony 7.3 is just around the corner as well as the first release of the component. Did you have time to start the work? 🙂 If you don't, please tell me if I can take over. Thanks!

@RisingSunLight42
Copy link
Contributor

Hi @RisingSunLight42, Symfony 7.3 is just around the corner as well as the first release of the component. Did you have time to start the work? 🙂 If you don't, please tell me if I can take over. Thanks!

I started a rough thinking of it (nothing written, just plan and how organizing everything). I plan on opening a draft PR in the next days (probably today or tomorrow) with the basic structure and wording. I'm fine with you taking over if you want, I got unexpectedly busy the last weeks so everything did not flow as I planned 😕.

For the plan, I was planning to do something similar to the YAML Component doc, obviously with adaptations for the JsonPath component. So something to explain why using it instead of json_decode for example, then the basic uses (mostly what was detailed in the PR) and the a more in-depth explanation method by method.

@alexandre-daubois
Copy link
Member

If you have a draft PR, let's not lose your work and iterate on it. Docs core team and contributors will be able to give you feedback and get this to the finish line 👍

@RisingSunLight42 RisingSunLight42 linked a pull request May 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants